fix(maintenance): resolve SAME_AS_SERVER timezone from TZ env var#262
Open
brewle wants to merge 1 commit into0xfurai:mainfrom
Open
fix(maintenance): resolve SAME_AS_SERVER timezone from TZ env var#262brewle wants to merge 1 commit into0xfurai:mainfrom
brewle wants to merge 1 commit into0xfurai:mainfrom
Conversation
✅ Deploy Preview for docspeekaping ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for peekaping ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
In distroless/scratch container images, time.Now().Location().String() always returns UTC regardless of TZ environment variable, because tzdata and /usr/share/zoneinfo are not available. Fix: read timezone from TZ env var first, fall back to time.Now().Location() for non-containerized deployments. Fixes 0xfurai#261
brewle
force-pushed
the
fix/maintenance-timezone-same-as-server
branch
from
be63469 to
c11479a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: In Alpine-based container images without
tzdata,time.LoadLocation("Europe/Kyiv")fails silently and falls back to UTC. Additionally,time.Now().Location().String()always returnsUTCregardless ofTZenvironment variable when/usr/share/zoneinfois not available.Fix:
TZenv var first forSAME_AS_SERVERcase, fall back totime.Now().Location()for non-containerized deploymentstzdatato all Alpine-based Dockerfiles sotime.LoadLocation()can resolve named timezones correctlyFixes #261