-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A tiny bug in BoundingBox.draw() #736
Conversation
Fixed a tiny bug in draw function
|
Can you explain please? A |
If you run
|
Okay, got it -- but if you remove the Also, can you send me a screenshot of the bounding box tests, to verify that no new issues are introduced? :-) |
As shown above, the I think it's OK to call |
Just catching up on this -- in fact, it appears I made an error when first implementing So: in fact, the issue is in the Did all the visual regression tests pass? It's entirely possible that this bug isn't causing any visual differences between the two, given how rarely |
Thanks @gristow -- I had the same thought and was just about to tag you in. Removing the If the fix is simple enough, I'd prefer to fix @zyuchuan, thanks for catching this bug! :-) |
No description provided.