Feature: Allow getting all staff modifiers by category, without position #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xfe
reviewed
Nov 15, 2019
src/stave.js
Outdated
| @@ -337,6 +337,9 @@ export class Stave extends Element { | |||
| clefs[0].setType(clefSpec, size, annotation); | |||
| } | |||
|
|
|||
| const keySignatures = this.getModifiers(position, KeySignature.CATEGORY); | |||
There was a problem hiding this comment.
These two lines look unrelated to the PR?
There was a problem hiding this comment.
You're right, this was my attempt to fix #727. Will remove
|
|
||
| return this.modifiers.filter(modifier => | ||
| position === modifier.getPosition() && | ||
| (position === undefined || position === modifier.getPosition()) && |
There was a problem hiding this comment.
This looks safe, but I'm hesitant to accept without making sure that there were no diffs in the visual regression tests. Can you confirm please?
There was a problem hiding this comment.
@0xfe Any suggestions on how I can confirm these tests pass? Having issues getting setup to run locally.
|
npm install + npm test: Not sure what I'm doing wrong... but the tests ran ok |
|
This was a broken build config. Closing and reopening to trigger a rebuild. |
|
Looks good. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if you want to getModifiers by category, you HAVE to have a position. This seems silly.