fix unnecessary shift #1372
Merged
fix unnecessary shift #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xfe
reviewed
Apr 11, 2022
| @@ -259,6 +259,12 @@ export class StaveNote extends StemmableNote { | |||
| // shift lower voice right | |||
| noteL.note.setXShift(xShift); | |||
| } | |||
| } else if (noteU.note.hasStem()) { | |||
| noteU.stemDirection = -noteU.note.getStemDirection(); | |||
| noteU.note.setStemDirection(noteU.stemDirection); | |||
There was a problem hiding this comment.
Thanks Rodrigo. We should only change the stem direction in controlled situations. Can we move this into the if (voices != 2) branch? (otherwise we'll have weird issues with stems changing direction in other situations.)
There was a problem hiding this comment.
Hi Mohit, this is already, I believe, in a very controlled situation. All these conditions have to be fulfilled:
- there are two voices
- only one of the notes has stem (the other one is a whole)
- they are not in the same line
- they overlap (the stem overlaps with the whole)
There are no other visual differences in all the tests (this is the only one where the change of stem direction was applied)
There was a problem hiding this comment.
Thanks Rodrigo -- I didn't realize that this was inside the voices === 2 branch.
|
Looks good, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1365
Only one visual difference:
StaveNote Note_Heads_Placement___Simple Bravura
current
reference