-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore v3.0.9 URLs and Fix JSFiddle examples. #1356
Conversation
… the commit message summary for future GitHub releases.
…rn() to upgrade to VexFlow 4.
They are easier to maintain in the repository. If updates are required, just copy and paste the source into the target JSFiddle.
OK, I now have some time to finish this up. I searched for the top VexFlow examples and JSFiddles, and took a look at the broken examples. These are the URLs that the broken examples use:
A few JSFiddle examples (which are NOT broken) use these URLs:
This PR will fix the npmcdn.com and unpkg.com URLs, which will fix the most common JSFiddle examples. This PR will NOT fix the rawgit.com URL. |
Modify package.json to include version 3.0.9 files in the npm release. Fix JSFiddle examples. Improve the warning message in the version 3.0.9 files.
OK this is ready for review! Once this is merged, we can make a 4.0.2 release which includes the recent fixes. Let me know if there are any other open PRs that should go into this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I think that can be a separate PR. We can eventually move the docs and examples towards Factory API. |
Sorry I'm being really slow here. Is this still a work in progress? |
Ah sorry for not being clear. I've tested this and believe it's good to go. |
Looks good, thanks Ron. |
Work in progress: