Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1265: Fix issues with vertical placement of annotations #1270

Merged
merged 12 commits into from
Jan 15, 2022
Merged

fix #1265: Fix issues with vertical placement of annotations #1270

merged 12 commits into from
Jan 15, 2022

Commits on Dec 23, 2021

  1. fix 0xfe#1265 

    Fix some issues with placement.  Also  fix some issues found in my last accidental PR with articulation placement.  Because of an error in sign, a code leg would never have been traversed.  I added a test case for that and fixed the error.
    @AaronDavidNewman
    AaronDavidNewman committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    9b4afe4 View commit details
    Browse the repository at this point in the history

  2. fix failed test case due to annotation in ghost note

    @AaronDavidNewman
    AaronDavidNewman committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    85a9dbb View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2021

  1. Merge https://github.com/0xfe/vexflow into pr-1265

    @AaronDavidNewman
    AaronDavidNewman committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    63052e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. fix issues regarding annotations on tab notes

    @AaronDavidNewman
    AaronDavidNewman committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    b8c0ebf View commit details
    Browse the repository at this point in the history

  2. Merge https://github.com/0xfe/vexflow into pr-1265

    @AaronDavidNewman
    AaronDavidNewman committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    8567216 View commit details
    Browse the repository at this point in the history

  3. fix dependency

    @AaronDavidNewman
    AaronDavidNewman committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    092456c View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Merge https://github.com/0xfe/vexflow into pr-1265

    @AaronDavidNewman
    AaronDavidNewman committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    73039c4 View commit details
    Browse the repository at this point in the history

  2. Fix cases with TabNote, Bend and Annotation 

    Make Y position of Bend dependent on top string, like other modifiers
    @AaronDavidNewman
    AaronDavidNewman committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    caeb470 View commit details
    Browse the repository at this point in the history

  3. fix a merge issue in TabNote

    @AaronDavidNewman
    AaronDavidNewman committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    4462c86 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Merge https://github.com/0xfe/vexflow into pr-1265

    @AaronDavidNewman
    AaronDavidNewman committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    52e8716 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Merge https://github.com/0xfe/vexflow into pr-1265

    @AaronDavidNewman
    AaronDavidNewman committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    19ef952 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Fix lint warning in annotation.ts

    @0xfe
    0xfe authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6ab954e View commit details
    Browse the repository at this point in the history