Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application icon, a couple more exceptions in gitignore #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LevBernstein
Copy link
Contributor

@LevBernstein LevBernstein commented Apr 5, 2024

Uses the PlayerIcon file from Hearthstone_Data/Resources. I also increased the default window size for the login window, as I was getting annoyed at having to scroll.

@LevBernstein
Copy link
Contributor Author

@0xf4b1 Please review; do you think this enhancement would improve the project? Thanks. I've found that the default login window is too small, so I resized that, and I added an icon for the window just for fun.

@0xf4b1
Copy link
Owner

0xf4b1 commented Jun 10, 2024

hmm, I think this minor changes to the login app which actually only needs to be run once to get the token are not really necessary and the icon file still makes it path dependant

@LevBernstein
Copy link
Contributor Author

At the very least, increasing the window size would make it easier to navigate, no? Not having to scroll would be nice.

@0xf4b1
Copy link
Owner

0xf4b1 commented Jun 11, 2024

I cannot test at the moment.. I'm not aware that the login looks weird but I also haven't ran it since years because the token never expires once you have it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants