Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CoreFoundation #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expand CoreFoundation #33

wants to merge 2 commits into from

Conversation

Ice2501
Copy link

@Ice2501 Ice2501 commented Feb 20, 2023

Thanks for sharing your project, I'm working on expanding some bits.
This is my first batch of changes/ideas.

Other than adding some of the "useless" implementation details here, what this change allows us to do is to get rid of client.config entirely. One detail to figure out is how we offer the user to set their region, currently this is hard-coded in the stub which is less than ideal, open to suggestions.

I've also made fair progress on implementing the shop functionality ( blz_commerce_sdk_plugin ), let me know if you would be interested to see what I have for that.

@0xf4b1
Copy link
Owner

0xf4b1 commented Feb 20, 2023

Hey, thank you for helping to improve this project!

I'm not aware of problems with the client.config, are there advantages to provide the configuration options via the stub and add complexity for it? As you mention, it would be useful to have these options configurable and it sounds like we would have to introduce our own config file to read them from although the game already supports this with the client.config. 🤔

Getting the shop to work sounds interesting, I haven't looked into this so far mostly because I'm not using it.

@Ice2501
Copy link
Author

Ice2501 commented Feb 20, 2023

I think generally being as close to the official flow is desirable as some of the interfaces/loading mechanism may be subject to changes.

As an example, client.config did change in the past and broke some things for me; before I found your project I used to set Aurora.VerifyWebCredentials to the token I acquired, this was entirely disabled a while back. To be clear, what you're doing with it right now seems pretty generic, so this is more of a cosmetic/future proofing change if anything.

I'll push my work on blz_commerce_sdk_plugin.so once it's in a somewhat better state. Interestingly I also realized that Blizzard already ships a Linux native version of this interface for Android, but seemingly only arm64. The last universal APK (that has x86 libs) seems to be 15.2.34104 from about 4 years ago unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants