Various fixes from a copilot review#74
Open
jxy-s wants to merge 5 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| // changes. Also, we don't have access to the modern WFP here | ||
| // so show an old school message box. | ||
| // | ||
| if ((DateTime.Now - LastReloadErrorTime).Seconds > 3) |
There was a problem hiding this comment.
🟡 TimeSpan.Seconds used instead of TotalSeconds for error throttle check
TimeSpan.Seconds returns only the seconds component (0–59) of the time span, not the total elapsed seconds. If more than 60 seconds have passed since the last error (e.g., 62 seconds), .Seconds returns 2, causing 2 > 3 to be false and suppressing the error dialog even though it should be shown. The correct property is .TotalSeconds, which returns the full elapsed time in seconds (e.g., 62.0).
Suggested change
| if ((DateTime.Now - LastReloadErrorTime).Seconds > 3) | |
| if ((DateTime.Now - LastReloadErrorTime).TotalSeconds > 3) |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot found some problems and suggested some changes. They seem reasonable. Tested locally.