Fetch chain id in TRANSACTION_SUBMITTED if it has not been cached yet #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kquintal
approved these changes
Oct 9, 2023
… private function
…introduce custome error
gtupak
force-pushed
the
perf/request-chain-id
branch
from
2924a87 to
2c4bdfd
Compare
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/arcxmoney/sdk-api/issues/469
It is sometimes possible that the cached
chainIdto be undefined at the moment whenTRANSACTION_TRIGGEREDis to be fired, causing us to submit the event without achainId.In such cases, this PR now requests
eth_chainIdon the provider in an attempt to populate it.While at it, I also extracted the code inside
_trackTransactionsin a separate function to be able to test it.