Skip to content

Do not track password for personal_sign events #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

Do not track password for personal_sign events #146

merged 2 commits into from
Sep 15, 2023

Conversation

gtupak
Copy link
Collaborator

@gtupak gtupak commented Sep 11, 2023

Closes #139

@gtupak gtupak requested a review from kquintal September 15, 2023 16:28
kquintal
kquintal approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@kquintal kquintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha I remember talking about this at the retreat 🥼

@gtupak gtupak merged commit 1fb67ba into main Sep 15, 2023
@gtupak gtupak deleted the refactor/rm-personal-sign-pw branch September 15, 2023 21:16
@gtupak
Copy link
Collaborator Author

gtupak commented Sep 29, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kquintal kquintal kquintal approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the password attribute for personal_sign requests
2 participants
@gtupak @kquintal