Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Adapt to Starknet / cairo-lang 0.12.1a0 #516

Merged
merged 16 commits into from
Aug 3, 2023
Merged

Adapt to Starknet / cairo-lang 0.12.1a0 #516

merged 16 commits into from
Aug 3, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jul 20, 2023

Usage related changes

  • Adapt to cairo-lang / Starknet 0.12.1a0
  • Semantics of REVERTED and REJECTED is modified compared to the official testnet. Explained in the docs
    • rationale: couldn't make it work with REJECTED because of checks done in cairo-lang post_init

Development related changes

  • Update JSON validation files used in testing
  • Simplify tx storage in starknet_wrapper
  • Remove double background devnet spawning in test_general_workflow (the test had been passing but with some port collisions)
  • Add a couple of utility scripts, found them useful while developing, but they aren't a part of the necessary workflow:
    • scripts/compute_compiled_class_hash.py - for calculating the of a Cairo 1 Casm artifact
    • scripts/find_reverted.py - for finding reverted tx

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC changed the title Adapt to 0.12.1a0 Adapt to Starknet / cairo-lang 0.12.1a0 Aug 3, 2023
@FabijanC FabijanC marked this pull request as ready for review August 3, 2023 11:54
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks legit to me. In rust implementation, we will handle this in a proper way.

@FabijanC FabijanC merged commit 11ff917 into master Aug 3, 2023
@FabijanC FabijanC deleted the adapt-0.12.1a0 branch August 3, 2023 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants