Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Handle redeclaring cairo 1 #463

Merged
merged 3 commits into from
May 9, 2023
Merged

Handle redeclaring cairo 1 #463

merged 3 commits into from
May 9, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented May 8, 2023 •
edited
Loading

Usage related changes

Development related changes

N/A

Checklist:

  • Figured out why it fails for forking another Devnet - only fails if the origin is also Devnet (not often in practice - in fact the only place where I've seen it being used is Devnet's tests where it's simpler than relying on testnet as origin)
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC requested a review from mikiw May 9, 2023 11:45
@FabijanC FabijanC marked this pull request as ready for review May 9, 2023 12:27
@FabijanC FabijanC merged commit 732bace into master May 9, 2023
@FabijanC FabijanC deleted the fix-redeclare-forked branch May 9, 2023 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaring Cairo 1 Contract fail in forked mode
2 participants
@FabijanC @mikiw