This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-Memory Blockwatcher Syncing #857
In-Memory Blockwatcher Syncing #857
Changes from 1 commit
390b1dc
a794d50
8b4f762
9b26aba
63caae9
ad68771
e09a8cd
fa71b86
09cdaa5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this function should not take in an argument at all, since any call with
checkpointID != s.latestCheckpointID
will result in an error, which never occurs intentionally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure. Having a more permissive
Reset
would be dangerous when using this code in multiple different go-routines. I'm inclined to keep it the same in this case so that we're protected if someone ever tries to useReset
across go-routines. I'm interested to hear your thoughts on this thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I hadn't considered that use case for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only thought about it after you raised the question. We could hypothetically avoid this by merging the stack library with the blockwatcher, but I think it's better if we can swap out stack implementations easily in the future.