Improve logging #263

albrow · 2019-07-16T01:41:55Z

Summary of changes:

Use a logrus.Hook to add a peer ID for all logs when possible.
Change "connected to peer" and "disconnected from peer" messages in mesh-bootstrap from Trace to Info. These are the main and only responsibility of bootstrap nodes so it is appropriate to log them.
Add a new log message at level Info which logs the order hash only for any new valid orders. We still keep the Trace message which includes the entire order.
Rename some uses of the field name peerID to remotePeerID for clarity.

albrow added 6 commits July 15, 2019 18:27

Set peer connection log to Info in mesh-bootstrap

8d92eeb

Use a hook to add peer ID to all logs

2f4d78d

Remove/rename old logs with peerID

2f862ed

Don't bother checking if myPeerID already exists in log entries

58a3fe7

Log hash only at Info level for new valid orders

70ff415

Simplify converting peer ID to string

efc004a

albrow requested a review from fabioberger July 16, 2019 01:42

fabioberger approved these changes Jul 16, 2019

View reviewed changes

fabioberger merged commit 3de669b into development Jul 16, 2019

fabioberger deleted the feature/logging-improvements branch July 16, 2019 10:06

Provide feedback