-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip range-checking PUSH
operations in KERNEL
mode
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hratoanina
requested changes
Jul 9, 2024
I'm going to update the specs too, it's missing a mention of the new view |
hratoanina
reviewed
Jul 9, 2024
hratoanina
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
performance
Performance improvement related changes
specs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following internal discussion, as part of our assumptions are the
KERNEL
validity, as source of truth, we do not need to range-check the hardcodedPUSH
operations happening in context 0. This involves a newCpuGeneralColumnsView
to hold a temporary variable to account for the increased degree when filtering the associated CTL.This allows to massively reduce both
BytePackingStark
andMemoryStark
trace lengths, asPUSH
operations normally require a range-check on all bytes of the pushed value.Example on an ERC20 transfer:
17023
->537
363111
->232806
This PR also cleans-up the way
BytePackingOp
s are appended, by skipping empty sequences which would be filtered out after anyway.Idea initially suggested by @4l0n50.