Put kernel code in first MemBefore #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
reviewed
Apr 22, 2024
Nashtare
reviewed
Apr 23, 2024
evm_arithmetization/src/verifier.rs
Outdated
Comment on lines
1
to
11
| use anyhow::{ensure, Result}; | ||
| use ethereum_types::{BigEndianHash, U256}; | ||
| use itertools::Itertools; | ||
| use plonky2::field::extension::Extendable; | ||
| use plonky2::hash::hash_types::RichField; | ||
| use plonky2::plonk::config::GenericConfig; | ||
| use plonky2::field::polynomial::PolynomialValues; | ||
| use plonky2::fri::oracle::PolynomialBatch; | ||
| use plonky2::hash::hash_types::{HashOut, RichField}; | ||
| use plonky2::hash::merkle_tree::MerkleCap; | ||
| use plonky2::plonk::config::{GenericConfig, GenericHashOut}; | ||
| use plonky2::util::timing::TimingTree; | ||
| use plonky2::util::transpose; |
There was a problem hiding this comment.
Needs merge with latest feat/continuations
Nashtare
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the whole kernel code to the first
MemBeforetrace of a transaction, so that it doesn't need to be hashed inside the kernel.This removes around 10k rows of
Keccak, at the cost of 60k rows inMemBeforeandMemory(the extra rows inMemorywill be mitigated in a future PR).In addition, this solves a critical soundness problem, as the kernel code segment was completely prover-provided up to the hashing in
global main, which was allowing completely arbitrary code execution in the kernel.