Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup alloc / std imports for plonky2 #1518

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Cleanup alloc / std imports for plonky2 #1518

merged 2 commits into from
Feb 10, 2024

Conversation

Nashtare
Copy link
Collaborator

plonky2 is exporting the alloc crate even when std is enabled, which is somehow inconsistent.
This PR conditionally exports alloc only when std is not enabled.

@Nashtare Nashtare self-assigned this Feb 10, 2024
@Nashtare Nashtare added this to the Repository Refactor milestone Feb 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Nashtare Nashtare merged commit b600142 into 0xPolygonZero:main Feb 10, 2024
5 checks passed
@Nashtare Nashtare deleted the plonky2_alloc_imports branch February 10, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

Assignees

@Nashtare Nashtare

Labels
None yet
Projects
Zero EVM
Archived in project
Milestone
Repository Refactor
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashtare @muursh