-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy: fix Vec/String warnings #280
Conversation
clippy is still red; is this expected? |
yes:
There may be something else that I missed though, but until that PR is merged and release, this will be red. |
Winterfell v0.8.1 with these changes is now on crates.io. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good! I pushed a few commits which fixed the remaining errors and also rebased the branch be based on main
. This way, we can release miden-crypto
v0.8.1.
Describe your changes
This fixes the clippy warnings by using wildcard imports instead of name imports.
This requires changes downstream to winterfell, namely the
boxed
mod.Checklist before requesting a review
next
according to naming convention.