Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dsa): fix deserialization logic #266

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(dsa): fix deserialization logic #266

merged 1 commit into from
Jan 26, 2024

Conversation

birchmd
Copy link
Contributor

@birchmd birchmd commented Jan 25, 2024

Describe your changes

The deserialization of signatures was not working properly due to slicing the byte array twice. This PR fixes the issue and adds a test for round-trip serialization.

Fixes #265

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bobbinth bobbinth requested a review from Al-Kindi-0 January 26, 2024 04:34
Al-Kindi-0
Al-Kindi-0 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for fixing this!

@bobbinth bobbinth linked an issue Jan 26, 2024 that may be closed by this pull request
Deserialization: Entire signature should be sent in instead of the slice #265
Closed
@bobbinth bobbinth merged commit a4b82bb into 0xPolygonMiden:next Jan 26, 2024
10 checks passed
@bobbinth bobbinth mentioned this pull request Jan 27, 2024
Closed
@birchmd birchmd deleted the fix-signatiure-deserialization branch January 29, 2024 01:58
bobbinth pushed a commit that referenced this pull request Feb 14, 2024
@birchmd @bobbinth
fix(dsa): fix deserialization logic (#266)
3882e0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al-Kindi-0 Al-Kindi-0 Al-Kindi-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserialization: Entire signature should be sent in instead of the slice
3 participants
@birchmd @Al-Kindi-0 @bobbinth