Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added L2GasPriceSuggesterFactor config parameter to simulate estimated L2 gas price (EGP disabled) #2777

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Added L2GasPriceSuggesterFactor config parameter to simulate estimated L2 gas price (EGP disabled) #2777

merged 4 commits into from
Nov 10, 2023

Conversation

agnusmor
Copy link
Contributor

@agnusmor agnusmor commented Nov 10, 2023 •
edited
Loading

Closes #.

What does this PR do?

Adds L2GasPriceSuggesterFactor config parameter to "simulate" estimated L2 gas price when EGP is disabled.

The following configuration parameter has been added:

[Pool]
[Pool.EffectiveGasPrice]
L2GasPriceSuggesterFactor = 0.5

Reviewers

Main reviewers:

@ToniRamirezM
@joan-esteban

@agnusmor agnusmor added this to the v0.4.0 milestone Nov 10, 2023
@agnusmor agnusmor self-assigned this Nov 10, 2023
@cla-bot cla-bot bot added the cla-signed label Nov 10, 2023
tclemos
tclemos approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@tclemos tclemos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments as questions and suggestions, nothing that would possibly block the merging, but to be considered and check it they make sense to change something. Feel free to discard all of them if you think they don't apply.

config/environments/local/local.node.config.toml Show resolved Hide resolved
pool/config.go Show resolved Hide resolved
test/config/debug.node.config.toml Show resolved Hide resolved
test/config/test.node.config.toml Show resolved Hide resolved
@agnusmor agnusmor merged commit 29ceae4 into release/v0.4.0 Nov 10, 2023
@agnusmor agnusmor deleted the feature/egp-l2-gasprice-simulated branch November 10, 2023 16:10
agnusmor added a commit that referenced this pull request Nov 20, 2023
@agnusmor
Added L2GasPriceSuggesterFactor config parameter to simulate estimate…
521632d 
…d L2 gas price (EGP disabled) (#2777)

* added L2GasPriceSuggesterFactor config parameter to "simulate" estimated l2 gas price when egp is disabled

* fix L2GasPriceSuggesterFactor value in test config file

* fix L2GasPriceSuggesterFactor value in test config file

* update doc
@agnusmor agnusmor added the cherry-picked Content has been cherry-picked into a higher version branch label Nov 20, 2023
@agnusmor agnusmor mentioned this pull request Nov 20, 2023
Merged
agnusmor added a commit that referenced this pull request Nov 20, 2023
@agnusmor
Added L2GasPriceSuggesterFactor config parameter to simulate estimate…
5fcffeb 
…d L2 gas price (EGP disabled) (#2777) (#2805)

* added L2GasPriceSuggesterFactor config parameter to "simulate" estimated l2 gas price when egp is disabled

* fix L2GasPriceSuggesterFactor value in test config file

* fix L2GasPriceSuggesterFactor value in test config file

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclemos tclemos tclemos approved these changes

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@dpunish3r dpunish3r Awaiting requested review from dpunish3r

@ARR552 ARR552 Awaiting requested review from ARR552 ARR552 is a code owner

@joanestebanr joanestebanr Awaiting requested review from joanestebanr joanestebanr is a code owner

Assignees

@agnusmor agnusmor

Labels
cherry-picked Content has been cherry-picked into a higher version branch cla-signed config zkevm-seq-agg
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@agnusmor @tclemos @ToniRamirezM