Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check added to checkTrustedState #1255

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Check added to checkTrustedState #1255

merged 6 commits into from
Oct 18, 2022

Conversation

ARR552
Copy link
Contributor

@ARR552 ARR552 commented Oct 10, 2022

Closes #1250

What does this PR do?

This PR adds a check for the state root calculated by the sequencer.
If there is a problem with the state root, it will be detected and the synchronizer will reset the trusted state.

Reviewers

If there is a problem with the state root, , it will be detected and the synchronizer will reset the trusted state.
@cool-develope
Copy link
Contributor

ExecuteBatch is missing in the stateMock

Copy link
Contributor

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved but we need to investigate the test failures

@ARR552 ARR552 force-pushed the feature/#1250_check_root branch from f1bbe49 to 43df0e8 Compare October 18, 2022 07:24
@ARR552 ARR552 merged commit 9680e50 into develop Oct 18, 2022
@ARR552 ARR552 deleted the feature/#1250_check_root branch October 18, 2022 13:42
arnaubennassar added a commit that referenced this pull request Nov 28, 2022
* Bump github.com/urfave/cli/v2 from 2.16.3 to 2.20.2 (#1301)

Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.16.3 to 2.20.2.
- [Release notes](https://github.com/urfave/cli/releases)
- [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md)
- [Commits](urfave/cli@v2.16.3...v2.20.2)

---
updated-dependencies:
- dependency-name: github.com/urfave/cli/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/grpc from 1.49.0 to 1.50.1 (#1300)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.49.0 to 1.50.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.49.0...v1.50.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/jackc/pgx/v4 from 4.17.1 to 4.17.2 (#1215)

Bumps [github.com/jackc/pgx/v4](https://github.com/jackc/pgx) from 4.17.1 to 4.17.2.
- [Release notes](https://github.com/jackc/pgx/releases)
- [Changelog](https://github.com/jackc/pgx/blob/v4.17.2/CHANGELOG.md)
- [Commits](jackc/pgx@v4.17.1...v4.17.2)

---
updated-dependencies:
- dependency-name: github.com/jackc/pgx/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alonso <ARR551@protonmail.com>

* Feature/#1145 genesis refactor (#1211)

* Wip

* chainID from smc

* smc addresses

* linter

* docker compose

* chainID

* fix merge

* minor refactor

* e2e group 2 fixed

* Check added to checkTrustedState (#1255)

* Check added to checkTrustedState

If there is a problem with the state root, , it will be detected and the synchronizer will reset the trusted state.

* synchronizer test

* fixed not working deletion from the pool (#1307)

* trying to fix: "sequencer seems not to store the proper new state" (#1305)

* Resume WIP proof generation (#1306)

* Resume WIP proof generation on Aggregator start-up

* fix pointers

* fix pointers

* add inputProver to db

* check properly if a proof has been generated

* fix proof generation check

* Properly check tx hash in CheckSupersetBatchTransactions (#1127)

* Properly check tx hash in CheckSupersetBatchTransactions

* correct docker-compose file

* approve without genesis (#1312)

* approve without genesis

* network flag removed

* Fix pointer log (#1313)

* test/utils: provide 'ZKPROVER_URI' and 'MERKLETREE_URI' as env variables. [test/: operations/manager.go, e2e/boradcast_test.go]  (#1311)

* fix typos (#1314)

* fix the claim signature  (#1316)

* fix the claim signature

* fix config

* added failed_counter check to make txs invalid, if failed_counter is exceeded (#1318)

* add wait after verify batch mining tx (#1319)

* fixed failed -> invalid (#1322)

* hotfix

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alonso <ARR551@protonmail.com>
Co-authored-by: Alonso Rodriguez <ARR552@users.noreply.github.com>
Co-authored-by: Mikhail Wall <mikhwall@gmail.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
Co-authored-by: ToniRamirezM <toni@iden3.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong root from trusted state
3 participants