Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for forkID in the tool 'deployVerifier' #278

Merged
merged 1 commit into from
Jul 22, 2024
Merged

add support for forkID in the tool 'deployVerifier' #278

merged 1 commit into from
Jul 22, 2024

Conversation

krlosMata
Copy link
Contributor

@krlosMata krlosMata commented Jul 16, 2024 •
edited
Loading

Important note: this PR goes to main directky since banana development is being done in develop branch
This PR does the following:

@cla-bot cla-bot bot added the cla-signed label Jul 16, 2024
ignasirv
ignasirv previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

invocamanman
invocamanman previously approved these changes Jul 16, 2024
View reviewed changes
@krlosMata krlosMata requested a review from ignasirv July 16, 2024 12:40
ignasirv
ignasirv previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata dismissed stale reviews from ignasirv and invocamanman via a12cd9c July 17, 2024 22:15
@krlosMata krlosMata force-pushed the feature/multi-verifier branch from 35e5038 to a12cd9c Compare July 17, 2024 22:15
ignasirv
ignasirv previously approved these changes Jul 18, 2024
View reviewed changes
invocamanman
invocamanman previously approved these changes Jul 18, 2024
View reviewed changes
@krlosMata @invocamanman
add support for forkID in the tool 'deployVerifier'
547d0f0 
addRollupType tool improvement

PR review 1

genesis

update verifier deployment
@invocamanman invocamanman force-pushed the feature/multi-verifier branch from a2be815 to 547d0f0 Compare July 18, 2024 18:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
53.3% Duplication on New Code

See analysis details on SonarCloud

@krlosMata krlosMata requested a review from ignasirv July 19, 2024 06:48
@krlosMata krlosMata merged commit 6486e02 into main Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@invocamanman invocamanman invocamanman approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @invocamanman