Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename handlertimeoutID #276

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Mar 30, 2023

Closes #NA

What does this PR does?

How to test?

  • CI should be green 🟢

Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Respect code style and lint
  • [-] Update documentation (if needed)

- the `setTimeout()` returns `timeoutID` a *positive integer* and not a `handler`
- ref: https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#return_value
@cla-bot
Copy link

cla-bot bot commented Mar 30, 2023

We require contributors/corporates @Pranav-yadav to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@Pranav-yadav
Copy link
Contributor Author

@elias-garcia I have read the CLA, now what? Where to sign (any specific website?).
The CLA signing flow is confusing here :)

@elias-garcia elias-garcia merged commit 9dc2669 into 0xPolygonHermez:develop Apr 3, 2023
@Pranav-yadav Pranav-yadav deleted the patch-1 branch April 3, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants