forked from erigontech/erigon
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(txpool): log nonce issues during transaction addition #1507
Merged
afa7789
merged 3 commits into
zkevm
from
1430-sequencer-debug-level-log-when-a-transaction-is-replaced
Nov 27, 2024
Merged
feat(txpool): log nonce issues during transaction addition #1507
afa7789
merged 3 commits into
zkevm
from
1430-sequencer-debug-level-log-when-a-transaction-is-replaced
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hexoscott 0xScott, can you see if this is what you were looking for ? |
mandrigin
reviewed
Nov 26, 2024
mandrigin
reviewed
Nov 26, 2024
hexoscott
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is along the lines of what we're looking for yep, just one thing around logging the account address.
Okay !
Thanks for the input, I will make the changes needed.
…On Tue, Nov 26, 2024, 16:54 Scott Fairclough ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I think this is along the lines of what we're looking for yep, just one
thing around logging the account address.
------------------------------
In zk/txpool/pool.go
<#1507 (comment)>
:
> @@ -1199,6 +1199,14 @@ func (p *TxPool) addLocked(mt *metaTx, announcements *types.Announcements) Disca
return NotReplaced
}
+ // Log nonce issue
+ log.Warn("Nonce issue detected",
+ "account", mt.Tx.SenderID,
sadly sender ID isn't so useful as it's just some number set by the pool
rather than an account address. Have a peek around and there are some
examples of getting the address back from this TX.
—
Reply to this email directly, view it on GitHub
<#1507 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGNEMF4P47VL47TRR5ARGDL2CRAL7AVCNFSM6AAAAABSP5NKUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRQHE2TQOJSGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
hexoscott
approved these changes
Nov 27, 2024
afa7789
deleted the
1430-sequencer-debug-level-log-when-a-transaction-is-replaced
branch
November 27, 2024 10:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.