This repository was archived by the owner on Feb 17, 2025. It is now read-only.
feature: storing LER in state.batch on successful transaction processing#2658
Merged
agnusmor merged 1 commit intorelease/v0.4.1from Nov 22, 2023
Merged
feature: storing LER in state.batch on successful transaction processing#2658agnusmor merged 1 commit intorelease/v0.4.1from
agnusmor merged 1 commit intorelease/v0.4.1from
Conversation
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Psykepro
requested review from
ToniRamirezM,
agnusmor and
tclemos
as code owners
agnusmor
approved these changes
Nov 22, 2023
agnusmor
pushed a commit
that referenced
this pull request
Nov 22, 2023
…ing (#2658) Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
agnusmor
added
the
cherry-picked
agnusmor
pushed a commit
that referenced
this pull request
Nov 22, 2023
…ing (#2658) Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
agnusmor
added a commit
that referenced
this pull request
Nov 23, 2023
…transaction processing (#2821) * feature: storing LER in state.batch on successful transaction processing (#2658) Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com> * fix doc --------- Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com> Co-authored-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2441.
What does this PR do?
Issue Fixed:
LocalExitRootis not updated correctly when a WIP batch with transactions is loaded after a Sequencer restart and then closed without adding any new transactions. This led to theLocalExitRootbeing stored as null, causing data inconsistencies.Changes Introduced:
UpdateBatchL2DataAndLERtoPostgresStorage.LocalExitRootto ensure it's updated appropriately, preventing it from being stored as null even after a sequencer restart.Reviewers