Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

remove unit suffix from duration config params#1927

Closed
tclemos wants to merge 19 commits intodevelopfrom
fix/duration-config
Closed

remove unit suffix from duration config params#1927
tclemos wants to merge 19 commits intodevelopfrom
fix/duration-config

Conversation

@tclemos
Copy link
Contributor

@tclemos tclemos commented Mar 24, 2023

Closes #1926.
Closes #926.

What does this PR do?

  • Fix duration parameters
  • Remove pricegetter as it was unused
  • Add a .md to document config parameters

Reviewers

Main reviewers:

@arnaubennassar
@ToniRamirezM

@tclemos tclemos requested a review from arnaubennassar March 24, 2023 17:41
@tclemos tclemos requested a review from ToniRamirezM as a code owner March 24, 2023 17:41
@tclemos tclemos self-assigned this Mar 24, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 24, 2023
@arnaubennassar arnaubennassar marked this pull request as draft March 24, 2023 18:47
@arnaubennassar arnaubennassar marked this pull request as ready for review April 4, 2023 15:36
@arnaubennassar arnaubennassar marked this pull request as draft April 11, 2023 08:51
@tclemos
Copy link
Contributor Author

tclemos commented May 2, 2023

closed due to #2068

@tclemos tclemos closed this May 2, 2023
@tclemos tclemos deleted the fix/duration-config branch May 2, 2023 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better documentation of config file Fix duration config parameter names

3 participants