Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

eth_getLogs topics param is not respected when a blockHash param is passed in #2359

@ahan-alchemy

Description

@ahan-alchemy

System information

zkEVM Node version: v0.2.1
OS & Version: ubuntu 20.04
Commit hash : (if develop)
Network: Mainnet

Expected behaviour

In eth_getLogs, im expecting the topic param to filter out data for a specific topic

Actual behaviour

It seems like it returns data for other topics not specified

curl --request POST      --url localhost:8545      --header 'accept: application/json'      --header 'content-type: application/json'      --data '{
      "jsonrpc": "2.0",
      "id": 1,
      "method": "eth_getLogs",
      "params": [
        {
          "blockHash": "0x17695bbbc7cb24f056472d70db4725a0ccb91aa1d8a3863c5c1fadba2916b966",
          "topics": [ [
        "0x7a53080ba414158be7ec69b987b5fb7d07dee101fe85488f0853ae16239d0bde",
        "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
        "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff88",
        "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4"
      ]]
        }
      ]
    }' | jq .result[].topics
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13935    0 13375  100   560   6215    260  0:00:02  0:00:02 --:--:--  6475
[
  "0x0c396cd989a39f4459b5fa1aed6a9a8dcdbc45908acfd67e028cd568da98982c",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4",
  "0x000000000000000000000000000000000000000000000000000000000000003c"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x0000000000000000000000009591b8a30c3a52256ea93e98da49ee43afa136a8",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x0000000000000000000000009591b8a30c3a52256ea93e98da49ee43afa136a8",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd"
]
[
  "0x70935338e69775456a85ddef226c395fb668b63fa0115f5f20610b388e6ca9c0",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4",
  "0x000000000000000000000000000000000000000000000000000000000000003c"
]
[
  "0x4606b8a47eb284e8e80929101ece6ab5fe8d4f8735acc56bd0c92ca872f2cfe7"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0x000000000000000000000000614ef8800ed585437bf67a689fc642e7a6f69d69"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0x000000000000000000000000614ef8800ed585437bf67a689fc642e7a6f69d69"
]
[
  "0x0c396cd989a39f4459b5fa1aed6a9a8dcdbc45908acfd67e028cd568da98982c",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff88",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4"
]
[
  "0x70935338e69775456a85ddef226c395fb668b63fa0115f5f20610b388e6ca9c0",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff88",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4"
]
[
  "0x4606b8a47eb284e8e80929101ece6ab5fe8d4f8735acc56bd0c92ca872f2cfe7"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x00000000000000000000000051c615b60f072a0f88032887cca08c8e257386e1",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x00000000000000000000000051c615b60f072a0f88032887cca08c8e257386e1",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0x0000000000000000000000009591b8a30c3a52256ea93e98da49ee43afa136a8"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0x0000000000000000000000009591b8a30c3a52256ea93e98da49ee43afa136a8"
]
[
  "0x598b9f043c813aa6be3426ca60d1c65d17256312890be5118dab55b0775ebe2a"
]
[
  "0x7a53080ba414158be7ec69b987b5fb7d07dee101fe85488f0853ae16239d0bde",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4",
  "0x000000000000000000000000000000000000000000000000000000000000003c"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0x0000000000000000000000009591b8a30c3a52256ea93e98da49ee43afa136a8"
]
[
  "0x7a53080ba414158be7ec69b987b5fb7d07dee101fe85488f0853ae16239d0bde",
  "0x000000000000000000000000145d55ae4848f9782efcac785a655e3e5dce1bcd",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff88",
  "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc4"
]
[
  "0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
  "0x0000000000000000000000000000000000000000000000000000000000000000",
  "0x00000000000000000000000051c615b60f072a0f88032887cca08c8e257386e1"
]
[
  "0x4e2ca0515ed1aef1395f66b5303bb5d6f1bf9d61a353fa53f73f8ac9973fa9f6",
  "0x00000000000000000000000051c615b60f072a0f88032887cca08c8e257386e1",
  "0x00000000000000000000000051c615b60f072a0f88032887cca08c8e257386e1"
]

Steps to reproduce the behavior

curl --request POST \
     --url localhost:8545 \
     --header 'accept: application/json' \
     --header 'content-type: application/json' \
     --data '{
      "jsonrpc": "2.0",
      "id": 1,
      "method": "eth_getLogs",
      "params": [
        {
          "blockHash": "0x17695bbbc7cb24f056472d70db4725a0ccb91aa1d8a3863c5c1fadba2916b966",
          "topics": ["0x7a53080ba414158be7ec69b987b5fb7d07dee101fe85488f0853ae16239d0bde"]
        }
      ]
    }'

Backtrace

[backtrace]

When submitting logs: please submit them as text and not screenshots.

cc: @rishub

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingrpc

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions