-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Change default jsonrpc binding to all interfaces (0.0.0.0) #435
Conversation
Adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Please don't merge this before #410
@ZeljkoBenovic |
Merged the Cobra CLI changes, changed default ip bindings and fixed few minor things with server cli command help output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
I've left some really minor comments 👍
* create struct for IPBindings * set additional param in ResolveAddr for default ip binding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR changes the default JSON PRC and Prometheus IP binding to all interfaces ( 0.0.0.0 ) instead of localhost/loopback ( 127.0.0.1 )
This makes much more sense when starting the chain with default settings as this APIs will usually be queried from remote hosts.
Fixed server command usage defaults. For example:
--max-outbound-peers int the client's max number of outbound peers allowed. Default: 8 (default -1)
now displays:
--max-outbound-peers int the client's max number of outbound peers allowed. (default 8)
Changes include
Checklist
Testing
Manual tests
Started the server with
--jsonrpc :10001
and without--jsonrpc
flag.Started the server with
--prometheus :5001
flag.The JSON RPC API always binds to all interfaces and can be queried from remote host
The Prometheus API binds to all interfaces on defined port
Documentation update
Doc PR#70
Additional comments
Fixes EDGE-421