-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to ethpandaops/ethereum-package
+ a few ci fixes
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethpandaops/ethereum-package
ethpandaops/ethereum-package
+ a few ci fix
ethpandaops/ethereum-package
+ a few ci fixethpandaops/ethereum-package
+ a few ci fixes
rebelArtists
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jarrodwatts
pushed a commit
to jarrodwatts/kurtosis-cdk
that referenced
this pull request
Jun 27, 2024
…Polygon#153) * chore: migrate to `ethpandaops/ethereum-package` * chore: bump pkg version * chore: bump kurtosis version * fix: typo * chore: test * test: 4.0.0 * chore: clean up * chore: bump to kurtosis-tech `0.90.1` * ci: fix typo * doc: fix typo * fix: pre-deployed-contracts job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ethereum-package has migrated from Kurtosis to the EF.
4.0.0
.0.90.1
.Notes:
The
cdk-erigon
job fails because there was a typo in the workflow file and since this PR relies on pull_request_target, it will fail until we merge the fix.There's another issue since we upgraded the kurtosis version. Kurtosis now checks that port names follow the RFC-6335 standard. It means that port names should be maximum 15 characters long. However, some of the blockscout services names are too long (Change service name to avoid kurtosis-cdk RFC 6335 error (length) xavier-romero/kurtosis-blockscout#4). Thus
incremental
fails because it deploys all the different components (note thatpre-deployed-contracts
also fails because it wrongly deploys all the components - this is fixed but it will reflect only after this PR has been merged).References (if applicable)