Add: Changes reverted in PR#1124#1204
Merged
anshalshukla merged 6 commits intodevelopfrom Apr 19, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.3.0-beta-candidate #1204 +/- ##
======================================================
Coverage 51.44% 51.44%
======================================================
Files 794 794
Lines 131304 131315 +11
======================================================
+ Hits 67549 67558 +9
+ Misses 59576 59573 -3
- Partials 4179 4184 +5 ☔ View full report in Codecov by Sentry. |
* fix: set balance in blockalloc * chg: don't update balance if not zero * fix: lint * fix logic, add test cases
Member
pratikspatil024
left a comment
There was a problem hiding this comment.
The base branch needs to be changed.
0xsharma
approved these changes
Apr 19, 2024
pratikspatil024
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds changes back from the reverted PR#1124
Changes:
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it