Skip to content

Update pebble from upstream#1196

Merged
anshalshukla merged 3 commits intodevelopfrom
update-pebble
Mar 21, 2024
Merged

Update pebble from upstream#1196
anshalshukla merged 3 commits intodevelopfrom
update-pebble

Conversation

@anshalshukla
Copy link
Contributor

Description

Cherry-picks commits from geth

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

magicxyyz and others added 3 commits March 21, 2024 00:49
Adds 'released' flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.

Fixes #28565
The dependency was not really used anyway, so we can get rid of it.

Co-authored-by: Felix Lange <fjl@twurst.com>
@anshalshukla anshalshukla requested a review from a team March 20, 2024 19:37
@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.46%. Comparing base (d9c6d12) to head (2866972).
Report is 1 commits behind head on develop.

Files Patch % Lines
ethdb/pebble/pebble.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1196      +/-   ##
===========================================
+ Coverage    51.40%   51.46%   +0.06%     
===========================================
  Files          794      794              
  Lines       131301   131301              
===========================================
+ Hits         67490    67575      +85     
+ Misses       59638    59549      -89     
- Partials      4173     4177       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshalshukla anshalshukla merged commit 5461f9b into develop Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants