feat: migrate to miden VM 0.21 and miden crypto 0.22#2508
Open
PhilippGackstatter wants to merge 52 commits intopgackst-asset-layoutfrom
Open
feat: migrate to miden VM 0.21 and miden crypto 0.22#2508PhilippGackstatter wants to merge 52 commits intopgackst-asset-layoutfrom
PhilippGackstatter wants to merge 52 commits intopgackst-asset-layoutfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
miden-air,winterfell,winter-rand-utils,winter-airagglayerbranch.StackInputsandStackOutputssince this changed in the VM.PartialSmthas changed which is why aPartialAccountTreetest needed an update (upsert_state_commitments_fails_on_untracked_key).constfrom someAccountIdmethods due toas_canonical_u64not beingconst(which replaces the previouslyconst fn as_int).RATE0, RATE1, CAPACITYas the hasher state. Previously the order of the rate words was not documented (RATE, RATE) and after hashing we sometimes usedPERM, PERM, PERMwhich doesn't say much. Not yet fully converted in this PR -> done as a follow-up.NOTE_ATTACHMENTandNOTE_METADATA_HEADER.swapwin the kernel if we re-arranged how the hash is defined (though this isn't done in this PR, and I'm not fully convinced yet it's worth doing).1to fix the cargo deny check that complained about two versions being used.tiny-keccak.Migration
[prefix, suffix]was changed to[suffix, prefix]for all slot IDs and account IDs (and the newly introduced asset ID). Note that slot IDs can still be pushed withpush.SLOT_NAME[0..2]. See the diff ofdocs/src/protocol_library.mdwith the previous version for what has changed inmiden::protocol.TokenMetadatachanges from stack[token_symbol, decimals, max_supply, token_supply]to[token_supply, max_supply, decimals, token_symbol].Follow-Ups
Done in #2512 except for the agglayer ones.
TODO(bele). Some of these are agglayer-related.adv.insert_hqwordcan be used.Signature,AuthScheme,AuthSecretKeytoFalcon512Poseidon2.Thanks to @Al-Kindi-0 and @huitseeker for their prior migration work that was a great reference, and the support in DMs!