chore: use EthAmount directly in tests#2455
Merged
partylikeits1983 merged 1 commit intoajl-u256-felt-downscale-procedurefrom Feb 18, 2026
Merged
chore: use EthAmount directly in tests#2455partylikeits1983 merged 1 commit intoajl-u256-felt-downscale-procedurefrom
partylikeits1983 merged 1 commit intoajl-u256-felt-downscale-procedurefrom
Conversation
mmagician
added
no changelog
partylikeits1983
merged commit 53825b5
into
ajl-u256-felt-downscale-procedure
18 checks passed
partylikeits1983
added a commit
that referenced
this pull request
Feb 18, 2026
* wip: u256 to felt scaling procedure * refactor: pass quotient via stack * refactor: procedure comments * refactor: modify tests & use assertz * refactor: cleanup test helper inputs * refactor: cleanup tests * feat: add inline sanity check test * refactor: cleanup test * refator: simplify and rename to verify_u256_to_native_amount_conversion * refactor: import FUNGIBLE_ASSET_MAX_AMOUNT & use word::eqz * revert: rename to try_to_u64 * refactor: use Felt::MODULUS * refactor: simplify EthAmount * refactor: rename EthAmountError variants * refactor: renamed functions and refactored errors & conversion * fix: taplo fmt * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * chore: clean up EthAmountError enum and improve docs * refactor: cleanup doc comments and test case * refactor: use existing error messages * fix: update global_index to use little-endian format * fix: clean up test_utils and crypto_utils files with agglayer-new changes * fix: rm unused function * chore: merge agglayer-new * feat: encorporate endianness reveral procedure * feat: clean up tests & add fuzzing test * refactor: add byte ordering comment & add testing attribute for from_u256 * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/agglayer/asset_conversion.rs Co-authored-by: Marti <marti@miden.team> * refactor: cleanup fuzzing test & address comments * chore: use EthAmount directly in tests (#2455) --------- Co-authored-by: Marti <marti@miden.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.