refactor: encapsulate agglayer faucet and bridge creation in structs#2454
Closed
johnh4098 wants to merge 1 commit into0xMiden:nextfrom
Closed
refactor: encapsulate agglayer faucet and bridge creation in structs#2454johnh4098 wants to merge 1 commit into0xMiden:nextfrom
johnh4098 wants to merge 1 commit into0xMiden:nextfrom
Conversation
johnh4098
force-pushed
the
refactor-agglayer-structs
branch
from
8f61583 to
e0e7c18
Compare
replace create_agglayer_faucet_component() and create_bridge_account_component() with AggLayerFaucet and AggLayerBridge structs that implement Into<AccountComponent>. uses TokenMetadata instead of manually constructing the metadata word. closes 0xMiden#2371
johnh4098
force-pushed
the
refactor-agglayer-structs
branch
from
e0e7c18 to
46dcb59
Compare
Collaborator
|
thanks but we already have a PR open for this issue: #2379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace create_agglayer_faucet_component() and create_bridge_account_component() with AggLayerFaucet and AggLayerBridge structs that implement Into. uses TokenMetadata instead of manually constructing the metadata word.
closes #2371