Skip to content

chore(Agglayer): refactors to make scaling down easier#2446

Merged
mmagician merged 10 commits intoagglayer-newfrom
mmagician-real-claim-followups
Feb 16, 2026
Merged

chore(Agglayer): refactors to make scaling down easier#2446
mmagician merged 10 commits intoagglayer-newfrom
mmagician-real-claim-followups

Conversation

@mmagician
Copy link
Collaborator

Two small refactors described in #2331 (comment):

  • the test vectors should generate a uint string with amounts, not a hex string
    • this PR is using U256 internally-only, while still keeping only two constructors: new(bytes: [u8; 32]) & from_uint_str(s: &str)
  • the amount & destination address should be extracted to stack before validate_claim, saved to memory locals, and passed on stack "as arguments" to the build_p2id_output_note procedure

@mmagician mmagician added agglayer PRs or issues related to AggLayer bridging integration pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority labels Feb 15, 2026
Copy link
Contributor

@partylikeits1983 partylikeits1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm glad we added back the primitive-types U256 dependency :)

@partylikeits1983 partylikeits1983 added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Feb 16, 2026
@mmagician mmagician merged commit c3b4497 into agglayer-new Feb 16, 2026
15 of 18 checks passed
@mmagician mmagician deleted the mmagician-real-claim-followups branch February 16, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agglayer PRs or issues related to AggLayer bridging integration no changelog This PR does not require an entry in the `CHANGELOG.md` file pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants