Skip to content

refactor(agglayer): simplify stack operations and clarify FPI comments#2440

Merged
mmagician merged 1 commit intommagician-cursor-agglayer-faucet-registry-5caffrom
copilot/sub-pr-2426
Feb 16, 2026
Merged

refactor(agglayer): simplify stack operations and clarify FPI comments#2440
mmagician merged 1 commit intommagician-cursor-agglayer-faucet-registry-5caffrom
copilot/sub-pr-2426

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

Address code review feedback to reduce cycle count and improve readability in agglayer faucet operations.

Changes

  • Simplified get_origin_token_address: Replace 5-operation sequence with movdn.7 drop drop drop (fewer cycles, clearer intent)
  • Improved formatting: Add blank line before repeat loop in asset_to_origin_asset
  • Clarified FPI stack comments: Update bridge_out.masm to show complete stack state after execute_foreign_procedure, making it explicit that destination data remains below the 16 returned elements
-    movup.3 drop movup.2 drop swap drop
-    # => [addr4, addr0, addr1, addr2, addr3]
-
-    # Reorder to [addr0, addr1, addr2, addr3, addr4]
-    movdn.4
+    movdn.7 drop drop drop
     # => [addr0, addr1, addr2, addr3, addr4]

Note: Did not adopt sys::truncate_stack suggestions as this utility does not exist in the codebase.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Implement AggLayer faucet registry for asset validation refactor(agglayer): simplify stack operations and clarify FPI comments Feb 12, 2026
Copilot AI requested a review from mmagician February 12, 2026 20:08
@mmagician mmagician force-pushed the mmagician-cursor-agglayer-faucet-registry-5caf branch from 61826f8 to ed8b51d Compare February 16, 2026 11:44
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
@mmagician mmagician marked this pull request as ready for review February 16, 2026 11:54
@mmagician mmagician merged commit bbf63b1 into mmagician-cursor-agglayer-faucet-registry-5caf Feb 16, 2026
14 of 15 checks passed
@mmagician mmagician deleted the copilot/sub-pr-2426 branch February 16, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants