feat(AggLayer claim e2e #1): Move padding to the end of NoteStorage for CLAIM note#2405
Merged
mmagician merged 3 commits intoagglayer-newfrom Feb 14, 2026
Merged
Conversation
mmagician
added
the
agglayer
mmagician
force-pushed
the
mmagician-padding-end-of-claim
branch
from
a9c26a1 to
c74188c
Compare
mmagician
changed the title
NoteStorage for CLAIM noteNoteStorage for CLAIM note
mmagician
commented
Feb 8, 2026
| @@ -1,5 +1,9 @@ | |||
| pub mod asset_conversion; | |||
| mod bridge_in; | |||
| // TODO: Uncomment this when https://github.com/0xMiden/miden-base/issues/2397 is ready. | |||
Collaborator
Author
There was a problem hiding this comment.
this is re-enabled in the last PR of the series in chore: re-enable bridge-in tests
mmagician
commented
Feb 8, 2026
Comment on lines
+52
to
+56
| /* | ||
| // TODO: Uncomment this when https://github.com/0xMiden/miden-base/issues/2397 is ready. | ||
| // The mainnet exit root is hardcoded to pass the current test (i.e. we set the expected mainnet | ||
| // root to whatever the current implementation computes), and changing any impl. details will break | ||
| // the test, forcing us to artificially change the expected root every time. |
Collaborator
Author
There was a problem hiding this comment.
this test data is eventually removed in 034d539
mmagician
added
the
pr-from-maintainers
partylikeits1983
approved these changes
Feb 13, 2026
Contributor
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks good and makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for byte-packing (PR coming), which will work off the assumption that aside from the first
leafTypefield element (unpacked), all the others are already packed (i.e. will use all its packed bytes in the hash computation).If we have padding in between elements, this no longer holds.
This PR comes with one less-than-ideal consequence, namely that we can no longer load the asset amount with 2x
mem_loadw_bebut have to load the individual elements, since the asset amount address is no longer word-aligned.