fix(AggLayer): use correct byte<>Felt conversion#2387
Merged
mmagician merged 9 commits intoagglayer-newfrom Feb 6, 2026
Merged
fix(AggLayer): use correct byte<>Felt conversion#2387mmagician merged 9 commits intoagglayer-newfrom
Felt conversion#2387mmagician merged 9 commits intoagglayer-newfrom
Conversation
mmagician
commented
Feb 2, 2026
partylikeits1983
approved these changes
Feb 5, 2026
Contributor
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks good!
However, should we merge agglayer-fixed-2 into next, then delete agglayer and create a new agglayer branch which is up to date with next?
Then rebase this PR off of next?
Co-authored-by: Alexander John Lee <77119221+partylikeits1983@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using
bytes_to_packed_u32_feltswhich reads the bytes as LE instead of BE, eliminating the mismatch:while at it, I unified the underlying representation of
ExitRootandSmtNodeto a singleKeccak256Output(any thoughts on the naming?) and use type aliases instead.