refactor: rename WellKnown.. types to Standard..#2332
Merged
bobbinth merged 5 commits into0xMiden:nextfrom Jan 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the WellKnown* note/component types to Standard* to align terminology with miden-standards (fixes #2284).
Changes:
- Renamed
WellKnownComponent→StandardAccountComponent,WellKnownNote→StandardNote, andWellKnownNoteAttachment→StandardNoteAttachment. - Updated all imports/usages across
miden-standards,miden-tx, andmiden-testing. - Added a BREAKING changelog entry for the rename.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/miden-tx/src/executor/notes_checker.rs | Switches note classification/ordering and static analysis checks to StandardNote. |
| crates/miden-testing/tests/scripts/faucet.rs | Updates test references to standardized note scripts via StandardNote. |
| crates/miden-testing/tests/agglayer/bridge_out.rs | Updates BURN script lookup to StandardNote. |
| crates/miden-testing/tests/agglayer/bridge_in.rs | Updates P2ID script lookup to StandardNote. |
| crates/miden-testing/src/kernel_tests/tx/test_account_interface.rs | Updates tests and expectations to use StandardNote. |
| crates/miden-standards/src/note/utils.rs | Uses StandardNote for standardized recipient/script helpers and tag derivation tests. |
| crates/miden-standards/src/note/standard_note_attachment.rs | Renames attachment enum/type to StandardNoteAttachment. |
| crates/miden-standards/src/note/standard_note.rs | Renames the standard note enum/type and related docs/usages. |
| crates/miden-standards/src/note/network_account_target.rs | Updates to StandardNoteAttachment for attachment scheme constants. |
| crates/miden-standards/src/note/mod.rs | Renames modules/exports to standard_* and re-exports new types. |
| crates/miden-standards/src/account/interface/extension.rs | Updates compatibility checks and component extraction to renamed types/methods. |
| crates/miden-standards/src/account/components/mod.rs | Renames component enum/type and extraction method. |
| crates/miden-standards/src/account/auth/falcon_512_rpo_acl.rs | Updates test helper usage to StandardAccountComponent. |
| crates/miden-standards/src/account/auth/ecdsa_k256_keccak_acl.rs | Updates test helper usage to StandardAccountComponent. |
| CHANGELOG.md | Documents the rename as a breaking change. |
Comments suppressed due to low confidence (1)
crates/miden-standards/src/note/standard_note.rs:109
- Doc comment mentions
miden-lib, but these types live inmiden-standards(and this PR is explicitly aligning terminology withmiden-standards). Consider updating the reference to avoid confusing crate users about where these standard notes come from.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@sashass1315 could you address the CI lints and see if the copilot comments make sense pls? thanks! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
Did it, thanks for review |
Contributor
Author
|
I'm sorry.. my bad, firstly i ran fmt, but then accepted copilot changes, so fmt broke again |
mmagician
pushed a commit
that referenced
this pull request
Jan 27, 2026
partylikeits1983
pushed a commit
that referenced
this pull request
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
WellKnownComponenttoStandardAccountComponent,WellKnownNotetoStandardNote, andWellKnownNoteAttachmenttoStandardNoteAttachment.fixes #2284