Skip to content

refactor: rename WellKnown.. types to Standard..#2332

Merged
bobbinth merged 5 commits into0xMiden:nextfrom
sashass1315:2284
Jan 23, 2026
Merged

refactor: rename WellKnown.. types to Standard..#2332
bobbinth merged 5 commits into0xMiden:nextfrom
sashass1315:2284

Conversation

@sashass1315
Copy link
Contributor

Renamed WellKnownComponent to StandardAccountComponent, WellKnownNote to StandardNote, and WellKnownNoteAttachment to StandardNoteAttachment.
fixes #2284

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the WellKnown* note/component types to Standard* to align terminology with miden-standards (fixes #2284).

Changes:

  • Renamed WellKnownComponentStandardAccountComponent, WellKnownNoteStandardNote, and WellKnownNoteAttachmentStandardNoteAttachment.
  • Updated all imports/usages across miden-standards, miden-tx, and miden-testing.
  • Added a BREAKING changelog entry for the rename.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/miden-tx/src/executor/notes_checker.rs Switches note classification/ordering and static analysis checks to StandardNote.
crates/miden-testing/tests/scripts/faucet.rs Updates test references to standardized note scripts via StandardNote.
crates/miden-testing/tests/agglayer/bridge_out.rs Updates BURN script lookup to StandardNote.
crates/miden-testing/tests/agglayer/bridge_in.rs Updates P2ID script lookup to StandardNote.
crates/miden-testing/src/kernel_tests/tx/test_account_interface.rs Updates tests and expectations to use StandardNote.
crates/miden-standards/src/note/utils.rs Uses StandardNote for standardized recipient/script helpers and tag derivation tests.
crates/miden-standards/src/note/standard_note_attachment.rs Renames attachment enum/type to StandardNoteAttachment.
crates/miden-standards/src/note/standard_note.rs Renames the standard note enum/type and related docs/usages.
crates/miden-standards/src/note/network_account_target.rs Updates to StandardNoteAttachment for attachment scheme constants.
crates/miden-standards/src/note/mod.rs Renames modules/exports to standard_* and re-exports new types.
crates/miden-standards/src/account/interface/extension.rs Updates compatibility checks and component extraction to renamed types/methods.
crates/miden-standards/src/account/components/mod.rs Renames component enum/type and extraction method.
crates/miden-standards/src/account/auth/falcon_512_rpo_acl.rs Updates test helper usage to StandardAccountComponent.
crates/miden-standards/src/account/auth/ecdsa_k256_keccak_acl.rs Updates test helper usage to StandardAccountComponent.
CHANGELOG.md Documents the rename as a breaking change.
Comments suppressed due to low confidence (1)

crates/miden-standards/src/note/standard_note.rs:109

  • Doc comment mentions miden-lib, but these types live in miden-standards (and this PR is explicitly aligning terminology with miden-standards). Consider updating the reference to avoid confusing crate users about where these standard notes come from.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mmagician
Copy link
Collaborator

@sashass1315 could you address the CI lints and see if the copilot comments make sense pls? thanks!

sashass1315 and others added 3 commits January 23, 2026 17:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sashass1315
Copy link
Contributor Author

@sashass1315 could you address the CI lints and see if the copilot comments make sense pls? thanks!

Did it, thanks for review

@sashass1315
Copy link
Contributor Author

I'm sorry.. my bad, firstly i ran fmt, but then accepted copilot changes, so fmt broke again

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 4864db0 into 0xMiden:next Jan 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename WellKnown* structs to Standard*

4 participants