Skip to content

Make TransactionAuthenticator return Arc for public key#2304

Merged
bobbinth merged 2 commits intonextfrom
bobbin-arc-pub-key
Jan 19, 2026
Merged

Make TransactionAuthenticator return Arc for public key#2304
bobbinth merged 2 commits intonextfrom
bobbin-arc-pub-key

Conversation

@bobbinth
Copy link
Contributor

@bobbinth bobbinth commented Jan 17, 2026

This PR changes the signature of TransactionAuthenticator::get_public_key() method to return Arc<PublicKey> instead of &PublicKey as per #2302.

closes #2302

@bobbinth bobbinth linked an issue Jan 17, 2026 that may be closed by this pull request
Copy link
Collaborator

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
So I think with the changes in this PR, we'll be able to implement this TODO properly then, without the internal cache in WebKeyStore.

Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bobbinth bobbinth merged commit 3ea9aa9 into next Jan 19, 2026
17 checks passed
@bobbinth bobbinth deleted the bobbin-arc-pub-key branch January 19, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change TransactionAuthenticator::get_public_key to return Arc<>`

4 participants