feat(AggLayer): implement verify_leaf#2295
Merged
mmagician merged 5 commits intommagician-verify-leaf-bridgefrom Jan 23, 2026
Merged
feat(AggLayer): implement verify_leaf#2295mmagician merged 5 commits intommagician-verify-leaf-bridgefrom
verify_leaf#2295mmagician merged 5 commits intommagician-verify-leaf-bridgefrom
Conversation
feat: fill some TODOs
mmagician
commented
Jan 16, 2026
Collaborator
Author
There was a problem hiding this comment.
copied from #2262, they'll eventually be merged
mmagician
added
the
agglayer
partylikeits1983
approved these changes
Jan 21, 2026
Contributor
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks good, I think once latest agglayer is merged, crates/miden-testing/tests/agglayer/test_utils.rs will already be available.
mmagician
added a commit
that referenced
this pull request
Feb 1, 2026
* feat: implement verify_leaf_bridge * chore: stack is empty, can swap instead of pad * chore: load leaf first, proof later * feat(AggLayer): implement `verify_leaf` (#2295) * feat: verify_leaf stubbed feat: fill some TODOs * chore: test global index processing * chore: update comments * self review * changelog * docs: add comment about exit root pointer locations in compute_ger Addresses PR feedback: clarify that mainnet exit root is at exit_roots_ptr and rollup exit root is at exit_roots_ptr + 8. Co-authored-by: marti <marti@hungrycats.studio> * refactor: remove unused verify_claim_proof procedure This procedure has been replaced by verify_merkle_proof and is no longer used. Co-authored-by: marti <marti@hungrycats.studio> * style: add section headers for better organization in bridge_in.masm Addresses PR feedback: organize the file with clear section headers for: - Constants (storage slots and memory layout) - Errors - Public interface procedures - Helper procedures Co-authored-by: marti <marti@hungrycats.studio> * fix: get leaf value is exec, should not truncate stack * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: add padding to stack comments * chore: make padding explicit for update ger * chore: update_ger proc is call not exec * chore: assert_valid_ger is not public * docs: make panics explicit; add verify steps * chore: fix indent for inline comment * chore: re-org procedures: pub/helper * chore: Word prefer empty over default * changelog: move entry 0.13 -> 0.14 --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #2288.
To complete the functionality here we also need
verify_merkle_proofimplemented, it's currently stubbed out.closes #2277