feat: rename NoteInputs to NoteStorage by Farukest · Pull Request #2282 · 0xMiden/protocol

Farukest · 2026-01-15T12:31:06Z

This commit renames the NoteInputs type to NoteStorage throughout the codebase to better reflect that these values represent stored data associated with a note rather than inputs.

Changes include:

Renamed NoteInputs struct to NoteStorage
Renamed inputs.rs to storage.rs
Updated MAX_INPUTS_PER_NOTE to MAX_NOTE_STORAGE_ITEMS
Updated all related method names: inputs() -> storage(), num_values() -> len(), values() -> items()
Updated all variable names: note_inputs -> note_storage
Updated Assembly files with new terminology
Updated error messages and constants
Updated documentation

Closes #1662

This commit renames the NoteInputs type to NoteStorage throughout the codebase to better reflect that these values represent stored data associated with a note rather than inputs. Changes include: - Renamed NoteInputs struct to NoteStorage - Renamed inputs.rs to storage.rs - Updated MAX_INPUTS_PER_NOTE to MAX_NOTE_STORAGE_ITEMS - Updated all related method names: inputs() -> storage(), num_values() -> len(), values() -> items() - Updated all variable names: note_inputs -> note_storage - Updated Assembly files with new terminology - Updated error messages and constants - Updated documentation Closes 0xMiden#1662

Farukest · 2026-01-15T13:28:15Z

@PhilippGackstatter #2008 is done . need review a lot of work here :)
Mentioned on #2266

PhilippGackstatter

Thanks a lot for taking this on!

Try searching for these strings in the codebase, and you'll find some occurrences that still need to be renamed:

NUM_INPUTS (probably to storage_length)
note's inputs
note inputs
INPUTS_COMMITMENT
p2id_inputs
p2ide_inputs
mint_inputs
create_p2ide_note_with_inputs(inputs: -> create_p2ide_note_with_storage(storage:

PhilippGackstatter · 2026-01-15T15:29:36Z

crates/miden-standards/asm/standards/notes/p2id.masm

 # =================================================================================================

-const ERR_P2ID_WRONG_NUMBER_OF_INPUTS="P2ID note expects exactly 2 note inputs"
+const ERR_P2ID_WRONG_NUMBER_OF_INPUTS="P2ID note expects exactly 2 note storage"


Suggested change

const ERR_P2ID_WRONG_NUMBER_OF_INPUTS="P2ID note expects exactly 2 note storage"

const ERR_P2ID_UNEXPECTED_STORAGE_LENGTH="P2ID note expects exactly 2 note storage items"

This needs a rename. Probably same for other notes, swap, mint, etc.

PhilippGackstatter · 2026-01-15T15:30:36Z

crates/miden-standards/asm/standards/notes/swap.masm

 # =================================================================================================

-const ERR_SWAP_WRONG_NUMBER_OF_INPUTS="SWAP script expects exactly 16 note inputs"
+const ERR_SWAP_WRONG_NUMBER_OF_INPUTS="SWAP script expects exactly 16 note storage"


Above this line, const SWAP_NOTE_INPUTS_NUMBER=16 -> const SWAP_NOTE_STORAGE_LENGTH=16.

Address review feedback: - Rename INPUT_NOTE_NUM_INPUTS_OFFSET to INPUT_NOTE_STORAGE_LENGTH_OFFSET - Rename INPUT_NOTE_INPUTS_COMMITMENT_OFFSET to INPUT_NOTE_STORAGE_COMMITMENT_OFFSET - Rename *_NUM_INPUTS constants to *_STORAGE_LENGTH - Rename ERR_*_WRONG_NUMBER_OF_INPUTS to ERR_*_UNEXPECTED_STORAGE_LENGTH - Rename mint_inputs.rs to mint_storage.rs - Update function names: parse_p2id_inputs -> parse_p2id_storage - Update error messages to use 'note storage items' terminology - Update test helpers and assertions

Farukest · 2026-01-15T18:33:36Z

@PhilippGackstatter all changes made. thank you.

PhilippGackstatter · 2026-01-16T14:39:57Z

@Farukest Thanks for the updates and the effort!

Try searching for these strings in the codebase, and you'll find some occurrences that still need to be renamed:
* NUM_INPUTS (probably to storage_length)
* note's inputs
* note inputs
* INPUTS_COMMITMENT

These can still be found in the code base and, e.g. "note inputs" should be renamed to "note storage". Could you give this another shot?

Let's also merge next.

…ts-to-note-storage # Conflicts: # crates/miden-protocol/src/transaction/kernel/advice_inputs.rs

- Rename P2ID_NOTE_NUM_INPUTS to P2ID_NOTE_STORAGE_LENGTH - Rename RPO_CLAIM_NOTE_INPUTS_COMMITMENT to RPO_CLAIM_NOTE_STORAGE_COMMITMENT - Update comments: "note inputs" -> "note storage" - Update error messages to use "note storage" terminology

Farukest · 2026-01-16T16:21:39Z

@Farukest Thanks for the updates and the effort!

Try searching for these strings in the codebase, and you'll find some occurrences that still need to be renamed:

NUM_INPUTS (probably to storage_length)

note's inputs

note inputs

INPUTS_COMMITMENT

These can still be found in the code base and, e.g. "note inputs" should be renamed to "note storage". Could you give this another shot?

Let's also merge next.

I got this @PhilippGackstatter . need review

PhilippGackstatter

Thanks! Looks good!

I left a few small comments, but mostly I think we should merge this sooner than later because keeping the PR up to date will be difficult due to the many parts it touches.

There are still many occurences of "note inputs" and related terms in the codebase (#2282) but these are also ok to fix in a subsequent PR, as long as we get the main ones here.

The most important outstanding thing is renaming active_note::get_inputs to get_storage.

crates/miden-agglayer/asm/note_scripts/B2AGG.masm

crates/miden-agglayer/src/lib.rs

crates/miden-protocol/asm/kernels/transaction/lib/prologue.masm

crates/miden-protocol/asm/protocol/active_note.masm

crates/miden-protocol/asm/protocol/note.masm

crates/miden-protocol/asm/protocol/tx.masm

crates/miden-protocol/asm/shared_utils/util/note.masm

crates/miden-protocol/src/transaction/tx_args.rs

Changes based on Philip's review comments: - B2AGG.masm: B2AGG_NOTE_INPUTS_COUNT → B2AGG_NOTE_STORAGE_LEN - B2AGG.masm: ERR_B2AGG_WRONG_NUMBER_OF_INPUTS → ERR_B2AGG_UNEXPECTED_STORAGE_LENGTH - lib.rs: claim_inputs → claim_storage_items - prologue.masm: INPUT_COMMITMENT → STORAGE_COMMITMENT in comment - active_note.masm: get_inputs → get_storage procedure rename - note.masm: various comment updates (inputs → storage) - shared_utils/note.masm: input values → storage values - tx_args.rs: storage_commitment |-> inputs → storage_commitment |-> storage_items - Updated all callers of get_inputs to get_storage

PhilippGackstatter · 2026-01-19T10:32:01Z

Could you merge in next @Farukest? Thanks!

…ts-to-note-storage

Farukest · 2026-01-19T23:44:03Z

Could you merge in next @Farukest? Thanks!

got this one @PhilippGackstatter

…ts-to-note-storage

PhilippGackstatter

Looks good to me!

Let's see if we can get a second review and then we'll merge it.

crates/miden-protocol/asm/kernels/transaction/lib/prologue.masm

crates/miden-protocol/asm/protocol/active_note.masm

crates/miden-protocol/asm/protocol/note.masm

crates/miden-standards/asm/standards/notes/mint.masm

crates/miden-tx/src/errors/mod.rs

crates/miden-tx/src/host/kernel_process.rs

Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>

partylikeits1983

Looks great! I think the only comment left to address is this one: #2282 (comment)

* feat: rename NoteInputs to NoteStorage This commit renames the NoteInputs type to NoteStorage throughout the codebase to better reflect that these values represent stored data associated with a note rather than inputs. Changes include: - Renamed NoteInputs struct to NoteStorage - Renamed inputs.rs to storage.rs - Updated MAX_INPUTS_PER_NOTE to MAX_NOTE_STORAGE_ITEMS - Updated all related method names: inputs() -> storage(), num_values() -> len(), values() -> items() - Updated all variable names: note_inputs -> note_storage - Updated Assembly files with new terminology - Updated error messages and constants - Updated documentation Closes #1662 * chore: complete note inputs to note storage rename Address review feedback: - Rename INPUT_NOTE_NUM_INPUTS_OFFSET to INPUT_NOTE_STORAGE_LENGTH_OFFSET - Rename INPUT_NOTE_INPUTS_COMMITMENT_OFFSET to INPUT_NOTE_STORAGE_COMMITMENT_OFFSET - Rename *_NUM_INPUTS constants to *_STORAGE_LENGTH - Rename ERR_*_WRONG_NUMBER_OF_INPUTS to ERR_*_UNEXPECTED_STORAGE_LENGTH - Rename mint_inputs.rs to mint_storage.rs - Update function names: parse_p2id_inputs -> parse_p2id_storage - Update error messages to use 'note storage items' terminology - Update test helpers and assertions * fix: rename remaining num_expected_inputs to expected_storage_length * chore: rename remaining note inputs references to note storage - Rename P2ID_NOTE_NUM_INPUTS to P2ID_NOTE_STORAGE_LENGTH - Rename RPO_CLAIM_NOTE_INPUTS_COMMITMENT to RPO_CLAIM_NOTE_STORAGE_COMMITMENT - Update comments: "note inputs" -> "note storage" - Update error messages to use "note storage" terminology * address PR review comments: rename get_inputs to get_storage Changes based on Philip's review comments: - B2AGG.masm: B2AGG_NOTE_INPUTS_COUNT → B2AGG_NOTE_STORAGE_LEN - B2AGG.masm: ERR_B2AGG_WRONG_NUMBER_OF_INPUTS → ERR_B2AGG_UNEXPECTED_STORAGE_LENGTH - lib.rs: claim_inputs → claim_storage_items - prologue.masm: INPUT_COMMITMENT → STORAGE_COMMITMENT in comment - active_note.masm: get_inputs → get_storage procedure rename - note.masm: various comment updates (inputs → storage) - shared_utils/note.masm: input values → storage values - tx_args.rs: storage_commitment |-> inputs → storage_commitment |-> storage_items - Updated all callers of get_inputs to get_storage * fix: correct NoteError import path after merge * fix: update generated files and fix import order * Apply suggestions from code review * chore: regenerate error files * chore: revert foreign_inputs_len change * Apply suggestions from code review Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> --------- Co-authored-by: Farukest <farukest@users.noreply.github.com> Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> Co-authored-by: Alexander John Lee <77119221+partylikeits1983@users.noreply.github.com>

Farukest force-pushed the feat/rename-note-inputs-to-note-storage branch 2 times, most recently from b42f11c to 9f3891d Compare January 15, 2026 13:07

Farukest force-pushed the feat/rename-note-inputs-to-note-storage branch from 9f3891d to 3e0929b Compare January 15, 2026 13:18

PhilippGackstatter reviewed Jan 15, 2026

View reviewed changes

fix: rename remaining num_expected_inputs to expected_storage_length

a312421

Farukest force-pushed the feat/rename-note-inputs-to-note-storage branch from d17b48c to a312421 Compare January 15, 2026 19:18

Farukest added 2 commits January 16, 2026 17:49

Merge remote-tracking branch 'origin/next' into feat/rename-note-inpu…

721d7a2

…ts-to-note-storage # Conflicts: # crates/miden-protocol/src/transaction/kernel/advice_inputs.rs

bobbinth mentioned this pull request Jan 16, 2026

feat: rename note inputs to note storage #2008

Closed

PhilippGackstatter reviewed Jan 17, 2026

View reviewed changes

Farukest added 3 commits January 20, 2026 01:55

Merge remote-tracking branch 'origin/next' into feat/rename-note-inpu…

5071302

…ts-to-note-storage

fix: correct NoteError import path after merge

f0e7791

fix: update generated files and fix import order

36bb7a7

Merge remote-tracking branch 'origin/next' into feat/rename-note-inpu…

2e55ee8

…ts-to-note-storage

PhilippGackstatter approved these changes Jan 20, 2026

View reviewed changes

PhilippGackstatter and others added 4 commits January 20, 2026 09:49

Apply suggestions from code review

4553bae

chore: regenerate error files

91fed29

chore: revert foreign_inputs_len change

1da48d5

Apply suggestions from code review

34ebadb

Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>

partylikeits1983 approved these changes Jan 20, 2026

View reviewed changes

PhilippGackstatter merged commit be6ea54 into 0xMiden:next Jan 20, 2026
16 checks passed

This was referenced Jan 20, 2026

chore: note inputs to note storage rename followup #2316

Merged

fix: rename note inputs to note storage in docs #2322

Merged

	const ERR_P2ID_WRONG_NUMBER_OF_INPUTS="P2ID note expects exactly 2 note storage"
	const ERR_P2ID_UNEXPECTED_STORAGE_LENGTH="P2ID note expects exactly 2 note storage items"

Conversation

Farukest commented Jan 15, 2026

Uh oh!

Farukest commented Jan 15, 2026

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

PhilippGackstatter Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

PhilippGackstatter Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Farukest commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhilippGackstatter commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Farukest commented Jan 16, 2026

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PhilippGackstatter commented Jan 19, 2026

Uh oh!

Farukest commented Jan 19, 2026

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

partylikeits1983 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Farukest commented Jan 15, 2026 •

edited

Loading

PhilippGackstatter commented Jan 16, 2026 •

edited

Loading

partylikeits1983 left a comment •

edited

Loading