chore: prepare split into protocol and standards

CHANGELOG.md

@@ -26,6 +26,7 @@
 - [BREAKING] Renamed `AccountProcedureInfo` into `AccountProcedureRoot` and remove storage offset and size ([#2162](https://github.com/0xMiden/miden-base/pull/2162)).
 - [BREAKING] Made `AccountProcedureIndexMap` construction infallible ([#2163](https://github.com/0xMiden/miden-base/pull/2163)).
 - [BREAKING] Renamed `tracked_procedure_roots_slot` to `trigger_procedure_roots_slot` in ACL auth components for naming consistency ([#2166](https://github.com/0xMiden/miden-base/pull/2166)).
+- [BREAKING] Refactor `miden-objects` and `miden-lib` into `miden-protocol` and `miden-standards` ([#2184](https://github.com/0xMiden/miden-base/pull/2184)).
 - [BREAKING] Migrated to `miden-vm` v0.20 and `miden-crypto` v0.19 ([#2158](https://github.com/0xMiden/miden-base/pull/2158)).
 - [BREAKING] Refactored `AccountStorageDelta` to use a new `StorageSlotDelta` type ([#2182](https://github.com/0xMiden/miden-base/pull/2182)).
 - [BREAKING] Refactored account component templates into `AccountStorageSchema` ([#2193](https://github.com/0xMiden/miden-base/pull/2193)).

crates/miden-lib/asm/kernels/transaction/lib/epilogue.masm

@@ -14,7 +14,7 @@ const ERR_EPILOGUE_TOTAL_NUMBER_OF_ASSETS_MUST_STAY_THE_SAME="total number of as
 
 const ERR_EPILOGUE_EXECUTED_TRANSACTION_IS_EMPTY="executed transaction neither changed the account state, nor consumed any notes"
 
-const ERR_AUTH_PROCEDURE_CALLED_FROM_WRONG_CONTEXT="auth procedure had been called from outside the epilogue"
+const ERR_EPILOGUE_AUTH_PROCEDURE_CALLED_FROM_WRONG_CONTEXT="auth procedure has been called from outside the epilogue"
 
 const ERR_EPILOGUE_NONCE_CANNOT_BE_0="nonce cannot be 0 after an account-creating transaction"
 
@@ -220,7 +220,7 @@ proc execute_auth_procedure
 
     # if auth procedure was called already, it must have been called by a user, which is disallowed
     exec.account::was_procedure_called
-    assertz.err=ERR_AUTH_PROCEDURE_CALLED_FROM_WRONG_CONTEXT
+    assertz.err=ERR_EPILOGUE_AUTH_PROCEDURE_CALLED_FROM_WRONG_CONTEXT
     # => [auth_procedure_ptr, AUTH_ARGS, pad(12)]
 
     # execute the auth procedure

crates/miden-lib/asm/miden/active_note.masm

@@ -2,7 +2,6 @@ use miden::core::mem
 
 use miden::kernel_proc_offsets
 use miden::note
-use miden::contracts::wallets::basic->wallet
 
 # ERRORS
 # =================================================================================================
@@ -260,64 +259,6 @@ pub proc get_script_root
     # => [SCRIPT_ROOT]
 end
 
-#! Adds all assets from the active note to the native account's vault.
-#!
-#! Inputs:  []
-#! Outputs: []
-@locals(1024)
-pub proc add_assets_to_account
-    # write assets to local memory starting at offset 0
-    # we have allocated 4 * MAX_ASSETS_PER_NOTE number of locals so all assets should fit
-    # since the asset memory will be overwritten, we don't have to initialize the locals to zero
-    locaddr.0 exec.get_assets
-    # => [num_of_assets, ptr = 0]
-
-    # compute the pointer at which we should stop iterating
-    mul.4 dup.1 add
-    # => [end_ptr, ptr]
-
-    # pad the stack and move the pointer to the top
-    padw movup.5
-    # => [ptr, EMPTY_WORD, end_ptr]
-
-    # loop if the amount of assets is non-zero
-    dup dup.6 neq
-    # => [should_loop, ptr, EMPTY_WORD, end_ptr]
-
-    while.true
-        # => [ptr, EMPTY_WORD, end_ptr]
-
-        # save the pointer so that we can use it later
-        dup movdn.5
-        # => [ptr, EMPTY_WORD, ptr, end_ptr]
-
-        # load the asset
-        mem_loadw_be
-        # => [ASSET, ptr, end_ptr]
-
-        # pad the stack before call
-        padw swapw padw padw swapdw
-        # => [ASSET, pad(12), ptr, end_ptr]
-
-        # add asset to the account
-        call.wallet::receive_asset
-        # => [pad(16), ptr, end_ptr]
-
-        # clean the stack after call
-        dropw dropw dropw
-        # => [EMPTY_WORD, ptr, end_ptr]
-
-        # increment the pointer and continue looping if ptr != end_ptr
-        movup.4 add.4 dup dup.6 neq
-        # => [should_loop, ptr+4, EMPTY_WORD, end_ptr]
-    end
-    # => [ptr', EMPTY_WORD, end_ptr]
-
-    # clear the stack
-    drop dropw drop
-    # => []
-end
-
 # HELPER PROCEDURES
 # =================================================================================================
 

crates/miden-lib/asm/miden/contracts/wallets/basic.masm

@@ -1,5 +1,6 @@
 use miden::native_account
 use miden::output_note
+use miden::active_note
 
 # CONSTANTS
 # =================================================================================================
@@ -59,3 +60,61 @@ pub proc move_asset_to_note
     exec.output_note::add_asset
     # => [ASSET, note_idx, pad(11)]
 end
+
+#! Adds all assets from the active note to the native account's vault.
+#!
+#! Inputs:  []
+#! Outputs: []
+@locals(1024)
+pub proc add_assets_to_account
+    # write assets to local memory starting at offset 0
+    # we have allocated 4 * MAX_ASSETS_PER_NOTE number of locals so all assets should fit
+    # since the asset memory will be overwritten, we don't have to initialize the locals to zero
+    locaddr.0 exec.active_note::get_assets
+    # => [num_of_assets, ptr = 0]
+
+    # compute the pointer at which we should stop iterating
+    mul.4 dup.1 add
+    # => [end_ptr, ptr]
+
+    # pad the stack and move the pointer to the top
+    padw movup.5
+    # => [ptr, EMPTY_WORD, end_ptr]
+
+    # loop if the amount of assets is non-zero
+    dup dup.6 neq
+    # => [should_loop, ptr, EMPTY_WORD, end_ptr]
+
+    while.true
+        # => [ptr, EMPTY_WORD, end_ptr]
+
+        # save the pointer so that we can use it later
+        dup movdn.5
+        # => [ptr, EMPTY_WORD, ptr, end_ptr]
+
+        # load the asset
+        mem_loadw_be
+        # => [ASSET, ptr, end_ptr]
+
+        # pad the stack before call
+        padw swapw padw padw swapdw
+        # => [ASSET, pad(12), ptr, end_ptr]
+
+        # add asset to the account
+        call.receive_asset
+        # => [pad(16), ptr, end_ptr]
+
+        # clean the stack after call
+        dropw dropw dropw
+        # => [EMPTY_WORD, ptr, end_ptr]
+
+        # increment the pointer and continue looping if ptr != end_ptr
+        movup.4 add.4 dup dup.6 neq
+        # => [should_loop, ptr+4, EMPTY_WORD, end_ptr]
+    end
+    # => [ptr', EMPTY_WORD, end_ptr]
+
+    # clear the stack
+    drop dropw drop
+    # => []
+end

crates/miden-lib/asm/note_scripts/P2ID.masm

@@ -1,6 +1,7 @@
 use miden::active_account
 use miden::account_id
 use miden::active_note
+use miden::contracts::wallets::basic->basic_wallet
 
 # ERRORS
 # =================================================================================================
@@ -47,6 +48,6 @@ begin
     exec.account_id::is_equal assert.err=ERR_P2ID_TARGET_ACCT_MISMATCH
     # => []
 
-    exec.active_note::add_assets_to_account
+    exec.basic_wallet::add_assets_to_account
     # => []
 end

crates/miden-lib/asm/note_scripts/P2IDE.masm

@@ -2,6 +2,7 @@ use miden::active_account
 use miden::account_id
 use miden::active_note
 use miden::tx
+use miden::contracts::wallets::basic->basic_wallet
 
 # ERRORS
 # =================================================================================================
@@ -64,7 +65,7 @@ proc reclaim_note
     # => []
 
     # add note assets to account
-    exec.active_note::add_assets_to_account
+    exec.basic_wallet::add_assets_to_account
     # => []
 end
 
@@ -130,7 +131,7 @@ begin
 
     if.true
         # we can safely consume the note since the active account is the target of the note
-        dropw exec.active_note::add_assets_to_account
+        dropw exec.basic_wallet::add_assets_to_account
         # => []
 
     else