Skip to content

chore: CodeBuilder followups #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbinth merged 3 commits into from
Dec 15, 2025
Merged

chore: CodeBuilder followups #2175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7eb13b
test: simplify codebuilder creation
igamigo Dec 13, 2025
d83cca4
Merge branch 'next' into igamigo-code-builder-followups
bobbinth Dec 13, 2025
3549da4
Merge branch 'next' into igamigo-code-builder-followups
bobbinth Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/miden-lib/src/utils/code_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ use crate::transaction::TransactionKernel;
/// 1. Create a new CodeBuilder with debug mode preference
/// 2. Add any required modules using `link_module()` or `with_linked_module()`
/// 3. Add libraries using `link_static_library()` / `link_dynamic_library()` as appropriate
/// 4. Parse your script with `parse_note_script()` or `parse_tx_script()`
/// 4. Compile your script with `compile_note_script()` or `compile_tx_script()`
///
/// Note that the Compiling methods consume the CodeBuilder, so if you need to parse
/// Note that the compiling methods consume the CodeBuilder, so if you need to compile
/// multiple scripts with the same configuration, you should clone the builder first.
///
/// ## Builder Pattern Example
Expand Down
32 changes: 15 additions & 17 deletions crates/miden-testing/src/kernel_tests/tx/test_fpi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async fn test_fpi_memory_single_account() -> anyhow::Result<()> {

let source_manager = Arc::new(DefaultSourceManager::default());
let foreign_account_component = AccountComponent::new(
CodeBuilder::with_kernel_library(source_manager.clone())
CodeBuilder::with_source_manager(source_manager.clone())
.compile_component_code("test::foreign_account", foreign_account_code_source)?,
vec![mock_value_slot0.clone(), mock_map_slot.clone()],
)?
Expand Down Expand Up @@ -343,14 +343,14 @@ async fn test_fpi_memory_two_accounts() -> anyhow::Result<()> {
";

let foreign_account_component_1 = AccountComponent::new(
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
CodeBuilder::default()
.compile_component_code("test::foreign_account_1", foreign_account_code_source_1)?,
vec![mock_value_slot0.clone()],
)?
.with_supports_all_types();

let foreign_account_component_2 = AccountComponent::new(
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
CodeBuilder::default()
.compile_component_code("test::foreign_account_2", foreign_account_code_source_2)?,
vec![mock_value_slot1.clone()],
)?
Expand Down Expand Up @@ -1326,10 +1326,9 @@ async fn test_nested_fpi_stack_overflow() -> anyhow::Result<()> {
mock_value_slot0 = mock_value_slot0.name(),
);

let last_foreign_account_code =
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
.compile_component_code("test::last_foreign_account", last_foreign_account_code_source)
.unwrap();
let last_foreign_account_code = CodeBuilder::default()
.compile_component_code("test::last_foreign_account", last_foreign_account_code_source)
.unwrap();
let last_foreign_account_component =
AccountComponent::new(last_foreign_account_code, vec![mock_value_slot0.clone()])
.unwrap()
Expand Down Expand Up @@ -1374,13 +1373,12 @@ async fn test_nested_fpi_stack_overflow() -> anyhow::Result<()> {
next_foreign_prefix = next_account.id().prefix().as_felt(),
);

let foreign_account_code =
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
.compile_component_code(
format!("test::foreign_account_chain_{foreign_account_index}"),
foreign_account_code_source,
)
.unwrap();
let foreign_account_code = CodeBuilder::default()
.compile_component_code(
format!("test::foreign_account_chain_{foreign_account_index}"),
foreign_account_code_source,
)
.unwrap();
let foreign_account_component = AccountComponent::new(foreign_account_code, vec![])
.unwrap()
.with_supports_all_types();
Expand Down Expand Up @@ -1493,7 +1491,7 @@ async fn test_nested_fpi_native_account_invocation() -> anyhow::Result<()> {
";

let foreign_account_component = AccountComponent::new(
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
CodeBuilder::default()
.compile_component_code("foreign_account", foreign_account_code_source)?,
vec![],
)?
Expand Down Expand Up @@ -1592,7 +1590,7 @@ async fn test_fpi_stale_account() -> anyhow::Result<()> {

let mock_value_slot0 = AccountStorage::mock_value_slot0();
let foreign_account_component = AccountComponent::new(
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
CodeBuilder::default()
.compile_component_code("foreign_account_invalid", foreign_account_code_source)?,
vec![mock_value_slot0.clone()],
)?
Expand Down Expand Up @@ -1700,7 +1698,7 @@ async fn test_fpi_get_account_id() -> anyhow::Result<()> {
";

let foreign_account_component = AccountComponent::new(
CodeBuilder::with_kernel_library(Arc::new(DefaultSourceManager::default()))
CodeBuilder::default()
.compile_component_code("foreign_account", foreign_account_code_source)?,
Vec::new(),
)?
Expand Down