Skip to content

Rename 'tracked' to 'trigger' for ACL procedure naming consistency#2166

Merged
bobbinth merged 6 commits intonextfrom
copilot/use-consistent-acl-procedure-names
Dec 13, 2025
Merged

Rename 'tracked' to 'trigger' for ACL procedure naming consistency#2166
bobbinth merged 6 commits intonextfrom
copilot/use-consistent-acl-procedure-names

Conversation

Copy link
Contributor

Copilot AI commented Dec 11, 2025

  • Rename TRACKED_PROCEDURE_ROOT_SLOT_NAME to TRIGGER_PROCEDURE_ROOT_SLOT_NAME in Rust files
  • Rename tracked_procedure_roots_slot() to trigger_procedure_roots_slot() method
  • Update storage slot name from tracked_procedure_roots to trigger_procedure_roots
  • Update MASM constant in rpo_falcon_512_acl.masm and ecdsa_k256_keccak_acl.masm
  • Update documentation and comments
  • Update test files and faucet files
  • Run linting and tests
  • Verify no remaining "tracked" references in ACL context
  • Add changelog entry

Summary

This PR renames "tracked" to "trigger" for ACL procedure naming consistency. The ACL components define procedures that determine whether authentication is required. The codebase was using "trigger procedure" and "tracked procedure" inconsistently, with MASM code primarily using "trigger" while Rust APIs used "tracked".

Changed to "trigger" because:

  1. "trigger" is used more often in the codebase
  2. "trigger" better captures the semantic meaning that these procedures "trigger authentication when called"

Security Summary

No security vulnerabilities were introduced. This is a straightforward renaming change that does not alter any logic or functionality.

Original prompt

This section details on the original issue you should resolve

<issue_title>Use consistent name for ACL trigger procedures</issue_title>
<issue_description>The ACL components define a set of procedures that determine whether authentication is required or not.

We currently use "trigger procedure" and "tracked procedure" inconsistently, and it would be good to resolve this. The MASM code primarily uses "trigger" while the Rust APIs more frequently use "tracked". This is also reflected in the slot names, e.g. AuthEcdsaK256KeccakAcl::tracked_procedure_roots_slot.

I don't have a strong preference, but "trigger" seems to be used more often, so maybe "tracked" should be changed to "trigger". Also, "trigger", to me, captures a little better that these "trigger authentication when called".

This affects at least:

  • AuthEcdsaK256KeccakAcl::tracked_procedure_roots_slot
  • AuthRpoFalcon512Acl::tracked_procedure_roots_slot

Including their documentation and the slot name itself.

cc @partylikeits1983 @mmagician for naming preferences

Context: #2025 (comment)</issue_description>

<agent_instructions>double check that there are no items with "tracked" left after you finish.
Make sure to run lint and test jobs (see Makefile for this)</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@mmagician Agreed on using "trigger"

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update ACL trigger procedures for consistent naming Rename 'tracked' to 'trigger' for ACL procedure naming consistency Dec 11, 2025
Copilot AI requested a review from mmagician December 11, 2025 10:17
Copilot AI and others added 2 commits December 11, 2025 11:12
- Rename TRACKED_PROCEDURE_ROOT_SLOT_NAME to TRIGGER_PROCEDURE_ROOT_SLOT_NAME
- Rename tracked_procedure_roots_slot() to trigger_procedure_roots_slot()
- Update storage slot names from 'tracked_procedure_roots' to 'trigger_procedure_roots'
- Update MASM constants in rpo_falcon_512_acl.masm and ecdsa_k256_keccak_acl.masm
- Update documentation and comments (num_tracked_procs -> num_trigger_procs)
- Update test files and faucet documentation

Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
@mmagician mmagician force-pushed the copilot/use-consistent-acl-procedure-names branch from 02119f6 to 218d85d Compare December 11, 2025 11:13
@mmagician
Copy link
Collaborator

@copilot add changelog entry for this PR number 2166

Copilot AI added a commit that referenced this pull request Dec 11, 2025
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 11, 2025

@copilot add changelog entry for this PR number 2166

Added changelog entry in commit 8a27f8a.

Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
@mmagician mmagician force-pushed the copilot/use-consistent-acl-procedure-names branch from 8a27f8a to 0ca259d Compare December 11, 2025 13:15
@mmagician mmagician marked this pull request as ready for review December 11, 2025 13:15
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(Though, I think the doc update should be rolled back.)

@bobbinth bobbinth merged commit c1ade39 into next Dec 13, 2025
18 checks passed
@bobbinth bobbinth deleted the copilot/use-consistent-acl-procedure-names branch December 13, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use consistent name for ACL trigger procedures

4 participants