Rename 'tracked' to 'trigger' for ACL procedure naming consistency#2166
Merged
Rename 'tracked' to 'trigger' for ACL procedure naming consistency#2166
Conversation
Copilot
AI
changed the title
[WIP] Update ACL trigger procedures for consistent naming
Rename 'tracked' to 'trigger' for ACL procedure naming consistency
Dec 11, 2025
- Rename TRACKED_PROCEDURE_ROOT_SLOT_NAME to TRIGGER_PROCEDURE_ROOT_SLOT_NAME - Rename tracked_procedure_roots_slot() to trigger_procedure_roots_slot() - Update storage slot names from 'tracked_procedure_roots' to 'trigger_procedure_roots' - Update MASM constants in rpo_falcon_512_acl.masm and ecdsa_k256_keccak_acl.masm - Update documentation and comments (num_tracked_procs -> num_trigger_procs) - Update test files and faucet documentation Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
02119f6 to
218d85d
Compare
Collaborator
|
@copilot add changelog entry for this PR number 2166 |
Copilot AI
added a commit
that referenced
this pull request
Dec 11, 2025
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Contributor
Author
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
8a27f8a to
0ca259d
Compare
PhilippGackstatter
approved these changes
Dec 11, 2025
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
(Though, I think the doc update should be rolled back.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRACKED_PROCEDURE_ROOT_SLOT_NAMEtoTRIGGER_PROCEDURE_ROOT_SLOT_NAMEin Rust filestracked_procedure_roots_slot()totrigger_procedure_roots_slot()methodtracked_procedure_rootstotrigger_procedure_rootsrpo_falcon_512_acl.masmandecdsa_k256_keccak_acl.masmSummary
This PR renames "tracked" to "trigger" for ACL procedure naming consistency. The ACL components define procedures that determine whether authentication is required. The codebase was using "trigger procedure" and "tracked procedure" inconsistently, with MASM code primarily using "trigger" while Rust APIs used "tracked".
Changed to "trigger" because:
Security Summary
No security vulnerabilities were introduced. This is a straightforward renaming change that does not alter any logic or functionality.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.