fix: advice inputs in TransactionInputs not being propagated (2)#2099
Merged
fix: advice inputs in TransactionInputs not being propagated (2)#2099
TransactionInputs not being propagated (2)#2099Conversation
PhilippGackstatter
approved these changes
Nov 15, 2025
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good!
This is a more minimal fix and doesn't break the serialization, so probably better to go ahead with this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2094. I'm using the same test, but instead of removing advice inputs, we are ensuring that
TransactionInputs.advice_inputsare always contained within theTransactionInputs.tx_args.advice_inputs.This PR is non-breaking s it does not change external interfaces or serialization formats - but it does increase the amount of data duplicated in the
TransactionInputsobject.This is a temporary fix until #1286 properly addresses the duplication of advice data in
TransactionInputs.