Merged
Conversation
Contributor
|
I self-reviewed the PR, and @Fumuran's changes look good to me. |
bobbinth
approved these changes
Nov 4, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you @Fumuran and @PhilippGackstatter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
miden-baseto be compatible withmiden-vmv0.19.0.Changes
*_loadwand*_storewprocedures to use the big-endian versions (*_loadw_beand*_storew_be).get_stack_word_beandget_stack_word_lemethods for theExecutionOutputExttrait.PartialVault,PartialStorageMap,PartialAccountTreeandPartialNullifierTreeto allow construction from a root. This was necessary to do here because the changes toPartialSmtwere breaking how the partial structs worked. This essentially addresses Allow constructing partial structs from a known root #1966, except for addingPartialVault::with_witnesses, which can be done separately if needed.miden-airto workspace dependencies, because it is easy to miss otherwise and is in the dependency tree anyway.closes #1966
Follow-Up: #2043