Add get_note_script() to DataStore#1981
Merged
partylikeits1983 merged 4 commits intonextfrom Oct 9, 2025
Merged
Conversation
partylikeits1983
added
the
no changelog
partylikeits1983
requested review from
PhilippGackstatter and
mmagician
and removed request for
PhilippGackstatter
partylikeits1983
changed the title
get_note_script() to DataStoreget_note_script() to DataStore
PhilippGackstatter
approved these changes
Oct 8, 2025
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
get_note_script()method to theDataStoretrait. This provides the foundation for enabling public output notes in the network transaction builder.This is the first of a couple PRs to tackle #1972