Conversation
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I mostly reviewed non-test code and left some small comments inline.
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
Only comments regarding AccountBuilder and some test nits. I only left nits for the ID tests, but they basically also apply to the nonce test. Very nice tests, though 🎉!
| end | ||
|
|
||
| #! Returns the id of the native account. | ||
| #! Returns the account nonce. |
There was a problem hiding this comment.
| #! Returns the account nonce. | |
| #! Returns the current account's nonce. |
Nit
Edit: Or better match it to how we write it for the native account.
|
@bobbinth one question about value names in our |
Not a strong preference, but if the context is easy to infer from the surrounding code/comments, I'd go for a shorter version. For example, if the procedure name is |
bobbinth
left a comment
There was a problem hiding this comment.
All looks good! Thank you!
This PR implements two new kernel procedures:
account_get_native_idreturns the ID of the native accountaccount_get_native_noncereturns the nonce of the native accountTODO:
Closes: #1836